[as2api-dev] [CVS trunk] Another little refactoring of text-generating code; classes/interfaces this time

David Holroyd dave at badgers-in-foil.co.uk
Sat, 02 Jul 2005 18:58:48 +0000


<html>
<head>
<style><!--
  body {background-color:#ffffff;}
  .file {border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;}
  .pathname {font-family:monospace; float:right;}
  .fileheader {margin-bottom:.5em;}
  .diff {margin:0;}
  .tasklist {padding:4px;border:1px dashed #000000;margin-top:1em;}
  .tasklist ul {margin-top:0;margin-bottom:0;}
  tr.alt {background-color:#eeeeee}
  #added {background-color:#ddffdd;}
  #addedchars {background-color:#99ff99;font-weight:bolder;}
  tr.alt #added {background-color:#ccf7cc;}
  #removed {background-color:#ffdddd;}
  #removedchars {background-color:#ff9999;font-weight:bolder;}
  tr.alt #removed {background-color:#f7cccc;}
  #info {color:#888888;}
  #context {background-color:#eeeeee;}
  td {padding-left:.3em;padding-right:.3em;}
  tr.head {border-bottom-width:1px;border-bottom-style:solid;}
  tr.head td {padding:0;padding-top:.2em;}
  .task {background-color:#ffff00;}
  .comment {padding:4px;border:1px dashed #000000;background-color:#ffffdd}
  .error {color:red;}
  hr {border-width:0px;height:2px;background:black;}
--></style>
</head>
<body>
<table cellspacing="0" cellpadding="0" border="0" rules="cols">
<tr class="head"><td colspan="4">Commit in <b><tt>trunk/as2api</tt></b><span id="info"> on MAIN</span></td></tr>
<tr><td><tt><a href="#file1">html_output.rb</a></tt></td><td align="right" id="added">+9</td><td align="right" id="removed">-7</td><td nowrap="nowrap" align="center"><a href="http://svn.badgers-in-foil.co.uk/viewcvs.cgi/as2api/trunk/as2api/html_output.rb?rev=173&amp;content-type=text/vnd.viewcvs-markup">173</a> <a href="http://svn.badgers-in-foil.co.uk/viewcvs.cgi/as2api/trunk/as2api/html_output.rb.diff?r1=173&amp;r2=174">-&gt;</a> <a href="http://svn.badgers-in-foil.co.uk/viewcvs.cgi/as2api/trunk/as2api/html_output.rb?rev=174&amp;content-type=text/vnd.viewcvs-markup">174</a></td></tr>
</table>
<pre class="comment">
Another little refactoring of text-generating code; classes/interfaces this time
</pre>
<hr /><a name="file1" /><div class="file">
<span class="pathname"><a
href="http://svn.badgers-in-foil.co.uk/viewcvs.cgi/as2api/trunk">trunk</a>/<a
href="http://svn.badgers-in-foil.co.uk/viewcvs.cgi/as2api/trunk/as2api">as2api</a></span><br />
<div class="fileheader"><big><b>html_output.rb</b></big> <small id="info"><a href="http://svn.badgers-in-foil.co.uk/viewcvs.cgi/as2api/trunk/as2api/html_output.rb?rev=173&amp;content-type=text/vnd.viewcvs-markup">173</a> <a href="http://svn.badgers-in-foil.co.uk/viewcvs.cgi/as2api/trunk/as2api/html_output.rb.diff?r1=173&amp;r2=174">-&gt;</a> <a href="http://svn.badgers-in-foil.co.uk/viewcvs.cgi/as2api/trunk/as2api/html_output.rb?rev=174&amp;content-type=text/vnd.viewcvs-markup">174</a></small></div>
<pre class="diff"><small id="info">--- trunk/as2api/html_output.rb	2005-07-02 18:10:57 UTC (rev 173)
+++ trunk/as2api/html_output.rb	2005-07-02 18:58:47 UTC (rev 174)
@@ -267,12 +267,11 @@
</small></pre><pre class="diff" id="context">   end
 
   def link_type(type, qualified=false, attrs={})
</pre><pre class="diff" id="added">+    attrs["title"] = type_description_for(type)
</pre><pre class="diff" id="context">     if type.instance_of?(ASInterface)
       attrs["class"] = "interface_name"
</pre><pre class="diff" id="removed">-      attrs["title"] = "Interface #{type.qualified_name}"
</pre><pre class="diff" id="context">     elsif type.instance_of?(ASClass)
       attrs["class"] = "class_name"
</pre><pre class="diff" id="removed">-      attrs["title"] = "Class #{type.qualified_name}"
</pre><pre class="diff" id="context">     elsif type == AS_VOID
       attrs["class"] = "void_name"
     end
</pre><pre class="diff"><small id="info">@@ -463,11 +462,7 @@
</small></pre><pre class="diff" id="context">   attr_accessor :prev_type, :next_type
 
   def generate_body_content
</pre><pre class="diff" id="removed">-      if @type.instance_of?(ASClass)
-	html_h1("Class "+@type.qualified_name)
-      elsif @type.instance_of?(ASInterface)
-	html_h1("Interface "+@type.qualified_name)
-      end
</pre><pre class="diff" id="added">+      html_h1(type_description_for(@type))
</pre><pre class="diff" id="context"> 
       type_hierachy(@type)
 
</pre><pre class="diff"><small id="info">@@ -1034,6 +1029,13 @@
</small></pre><pre class="diff" id="context">   package_dir_for(package) + "/" + page
 end
 
</pre><pre class="diff" id="added">+def type_description_for(as_type)
+  if as_type.instance_of?(ASClass)
+    "Class #{@type.qualified_name}"
+  elsif as_type.instance_of?(ASInterface)
+    "Interface #{@type.qualified_name}"
+  end
+end
</pre><pre class="diff" id="context"> 
 
 class PackageIndexPage &lt; BasicPage
</pre></div>
<center><small><a href="http://www.badgers-in-foil.co.uk/projects/cvsspam/" title="commit -&gt; email">CVSspam</a> 0.2.11</small></center>
</body></html>