<html>
<head>
<style><!--
body {background-color:#ffffff;}
.file {border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;}
.pathname {font-family:monospace; float:right;}
.fileheader {margin-bottom:.5em;}
.diff {margin:0;}
.tasklist {padding:4px;border:1px dashed #000000;margin-top:1em;}
.tasklist ul {margin-top:0;margin-bottom:0;}
tr.alt {background-color:#eeeeee}
#added {background-color:#ddffdd;}
#addedchars {background-color:#99ff99;font-weight:bolder;}
tr.alt #added {background-color:#ccf7cc;}
#removed {background-color:#ffdddd;}
#removedchars {background-color:#ff9999;font-weight:bolder;}
tr.alt #removed {background-color:#f7cccc;}
#info {color:#888888;}
#context {background-color:#eeeeee;}
td {padding-left:.3em;padding-right:.3em;}
tr.head {border-bottom-width:1px;border-bottom-style:solid;}
tr.head td {padding:0;padding-top:.2em;}
.task {background-color:#ffff00;}
.comment {padding:4px;border:1px dashed #000000;background-color:#ffffdd}
.error {color:red;}
hr {border-width:0px;height:2px;background:black;}
--></style>
</head>
<body>
<table cellspacing="0" cellpadding="0" border="0" rules="cols">
<tr class="head"><td colspan="4">Commit in <b><tt>trunk/as2api</tt></b><span id="info"> on MAIN</span></td></tr>
<tr><td><tt><a href="#file1">api_loader.rb</a></tt></td><td align="right" id="added">+1</td><td align="right" id="removed">-10</td><td nowrap="nowrap" align="center">287 -> 288</td></tr>
</table>
<pre class="comment">
Do refactoring suggested by the TODO comment
</pre>
<hr /><a name="file1" /><div class="file">
<span class="pathname">trunk/as2api</span><br />
<div class="fileheader"><big><b>api_loader.rb</b></big> <small id="info">287 -> 288</small></div>
<pre class="diff"><small id="info">--- trunk/as2api/api_loader.rb 2006-03-07 22:32:30 UTC (rev 287)
+++ trunk/as2api/api_loader.rb 2006-03-07 22:39:23 UTC (rev 288)
@@ -468,15 +468,6 @@
</small></pre><pre class="diff" id="context">
private
</pre><pre class="diff" id="removed">- def collect_package_types(package_name)
- # TODO: dump this and use ASPackage instead, now it's available
- @types.each do |type|
- if type.package_name == package_name
- yield type
- end
- end
- end
-
</pre><pre class="diff" id="context"> def import_types_into_namespace(type, local_namespace)
importer = type.import_manager
importer.each_type do |type_name|
</pre><pre class="diff"><small id="info">@@ -493,7 +484,7 @@
</small></pre><pre class="diff" id="context"> def import_packages_into_namespace(type, local_namespace)
importer = type.import_manager
importer.each_package do |package_name|
</pre><pre class="diff" id="removed">- collect_package_types(package_name.join(".")) do |package_type|
</pre><pre class="diff" id="added">+ @packages[package_name.join(".")].each_type do |package_type|
</pre><pre class="diff" id="context"> if local_namespace.has_key?(package_type.unqualified_name)
$stderr.puts "#{type.input_filename}: #{package_type.unqualified_name} already refers to #{local_namespace[package_type.unqualified_name].qualified_name}"
end
</pre></div>
<center><small><a href="http://www.badgers-in-foil.co.uk/projects/cvsspam/" title="commit -> email">CVSspam</a> 0.2.11</small></center>
</body></html>