From dave at badgers-in-foil.co.uk Wed Jun 2 23:27:54 2004 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Wed, 2 Jun 2004 23:27:54 +0000 Subject: [cvsspam-devel] [Fwd: Email generated by CVSSpam has no date header] In-Reply-To: <20040517100714.GA24256@vhost.badgers-in-foil.co.uk> References: <40A53AEF.1030609@ibanx.nl> <20040517100714.GA24256@vhost.badgers-in-foil.co.uk> Message-ID: <20040602232754.GA21205@vhost.badgers-in-foil.co.uk> --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 17, 2004 at 10:07:14AM +0000, David Holroyd wrote: > On Fri, May 14, 2004 at 11:32:31PM +0200, Bart Selders wrote: > > I just have setup CVS & CVSspam 0.2.9 on a standard linux redhat 9 box. > > Email generated from CVSspam arrives with no date header. > > ... I'll try to correct this oversight for the next release. Maybe you could give this patch a try? dave --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="smtp_data_header-patch.diff" Index: cvsspam.rb =================================================================== RCS file: /var/lib/cvs/cvsspam/cvsspam.rb,v retrieving revision 1.45 diff -u -r1.45 cvsspam.rb --- cvsspam.rb 17 Mar 2004 23:04:58 -0000 1.45 +++ cvsspam.rb 2 Jun 2004 23:24:47 -0000 @@ -35,6 +35,9 @@ a Thanks for a very cool program... installed and working nicely with the @repository_name patch (from ML archives in May) and also the Date patch from Jun 2nd. Unfortunately I don't know ruby so I thought it better to ask rather than break things: would it be possible to add an option to suppress the coloured diff portion of the output? Eg. I would just like to see the summary, log message (the links to viewcvs suffice to give diffs for those who need it). This would make the output more suitable for distribution to a large mailing list. TIA! -Ralph From Adam.Blomberg at plexus.com Thu Jun 10 16:02:40 2004 From: Adam.Blomberg at plexus.com (Adam Blomberg) Date: Thu, 10 Jun 2004 11:02:40 -0500 Subject: [cvsspam-devel] Feature request: --nodiff option? Message-ID: I must also give thanks for this wonderful notification script. I would very much like to see the nodiff feature. A blue-sky request would also include the ability to remove the diff if the email will exceed a certain size. This would help to prevent 30+ megabyte emails caused by large commits. Thanks, -Adam -----Original Message----- From: Ralph Siemsen [mailto:rsiemsen@rossvideo.com] Sent: Thursday, June 10, 2004 10:59 AM To: cvsspam-devel@lists.badgers-in-foil.co.uk Subject: [cvsspam-devel] Feature request: --nodiff option? Thanks for a very cool program... installed and working nicely with the @repository_name patch (from ML archives in May) and also the Date patch from Jun 2nd. Unfortunately I don't know ruby so I thought it better to ask rather than break things: would it be possible to add an option to suppress the coloured diff portion of the output? Eg. I would just like to see the summary, log message (the links to viewcvs suffice to give diffs for those who need it). This would make the output more suitable for distribution to a large mailing list. TIA! -Ralph _______________________________________________ cvsspam-devel mailing list cvsspam-devel@lists.badgers-in-foil.co.uk http://lists.badgers-in-foil.co.uk/mailman/listinfo/cvsspam-devel From dave at badgers-in-foil.co.uk Fri Jun 11 11:16:21 2004 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Fri, 11 Jun 2004 11:16:21 +0000 Subject: [cvsspam-devel] Feature request: --nodiff option? In-Reply-To: <40C87719.4040401@rossvideo.com> References: <40C87719.4040401@rossvideo.com> Message-ID: <20040611111621.GA23769@vhost.badgers-in-foil.co.uk> On Thu, Jun 10, 2004 at 10:58:33AM -0400, Ralph Siemsen wrote: > Unfortunately I don't know ruby so I thought it better to ask rather > than break things: would it be possible to add an option to suppress the > coloured diff portion of the output? Eg. I would just like to see the > summary, log message (the links to viewcvs suffice to give diffs for > those who need it). The code is written with something like this in mind, so it shouldn't be to much trouble to implement. I'll endeavour to add a configuration option, time permitting. dave From dave at badgers-in-foil.co.uk Fri Jun 11 11:49:34 2004 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Fri, 11 Jun 2004 11:49:34 +0000 Subject: [cvsspam-devel] Feature request: --nodiff option? In-Reply-To: References: Message-ID: <20040611114934.GB23769@vhost.badgers-in-foil.co.uk> On Thu, Jun 10, 2004 at 11:02:40AM -0500, Adam Blomberg wrote: > I must also give thanks for this wonderful notification script. Thanks, to both of you :) > I would very much like to see the nodiff feature. A blue-sky request would > also include the ability to remove the diff if the email will exceed a > certain size. This would help to prevent 30+ megabyte emails caused by > large commits. I've also received multi-megabyte emails from CVSspam a few times. I look on them as handy stress-tests for Mozilla/Thunderbird. I'll have a think about exither excluding the diff section, or maybe trying to limit the numbers of diffs included depending on the size of message generated so far. dave From piet at ahead-tech.net Thu Jun 17 18:14:47 2004 From: piet at ahead-tech.net (Piet De Jong) Date: Thu, 17 Jun 2004 20:14:47 +0200 Subject: [cvsspam-devel] WinCVS In-Reply-To: <20040617181009.16263.26746.Mailman@vhost.badgers-in-foil.co.uk> Message-ID: <001601c45496$ff5bf260$5000a8c0@laptoppiet> Hello I have cvsspam working fine when I do a commit through an ssh session, using the 'cvs commit ' - command. I receive email etc. However I mainly use a front-end called wincvs from my develop station, running on XP. When I do a commit, the mail does not get send. Is a 'remote' commit not supported by cvs, does it not execute the cvsspam - scripts ? Many thanks Piet From piet at totill.com Thu Jun 17 18:14:56 2004 From: piet at totill.com (piet@totill.com) Date: Thu, 17 Jun 2004 20:14:56 +0200 Subject: [cvsspam-devel] WinCVS In-Reply-To: <20040617181009.16263.26746.Mailman@vhost.badgers-in-foil.co.uk> Message-ID: <001701c45497$04d3a2b0$5000a8c0@laptoppiet> Hello I have cvsspam working fine when I do a commit through an ssh session, using the 'cvs commit ' - command. I receive email etc. However I mainly use a front-end called wincvs from my develop station, running on XP. When I do a commit, the mail does not get send. Is a 'remote' commit not supported by cvs, does it not execute the cvsspam - scripts ? Many thanks Piet From rsiemsen at rossvideo.com Thu Jun 17 18:36:40 2004 From: rsiemsen at rossvideo.com (Ralph Siemsen) Date: Thu, 17 Jun 2004 14:36:40 -0400 Subject: [cvsspam-devel] WinCVS In-Reply-To: <001601c45496$ff5bf260$5000a8c0@laptoppiet> References: <001601c45496$ff5bf260$5000a8c0@laptoppiet> Message-ID: <40D1E4B8.2060607@rossvideo.com> Piet De Jong wrote: > I have cvsspam working fine when I do a commit through an ssh session, > using the 'cvs commit ' - command. I receive email etc. > > However I mainly use a front-end called wincvs from my develop station, > running on XP. > When I do a commit, the mail does not get send. I have several people here using wincvs frontend and they are generating messages just as do the regular command-line users. I can't see why there would be any difference - are you all using the same access mechanism (eg. :pserver: or whatever)? Maybe wincvs has an option to not execute scripts on the server side (I believe there is a commandline option for this as well). You'd have to hunt around in the preferences options I guess. -Ralph From Adam.Blomberg at plexus.com Fri Jun 18 11:04:42 2004 From: Adam.Blomberg at plexus.com (Adam Blomberg) Date: Fri, 18 Jun 2004 06:04:42 -0500 Subject: [cvsspam-devel] WinCVS Message-ID: Piet, Are you running CVS using a CVS server or with file-based CVS? If you are running file-based CVS it may be that Windows doesn't have the ability to execute the Ruby scripts behind CVSSpam. If your SSH session is to a ruby-supported linux workstation or unix server, this may explain the inconsistency. I would suggest moving to server-based CVS if this is the case. Regards, -Adam -----Original Message----- From: Ralph Siemsen [mailto:rsiemsen@rossvideo.com] Sent: Thursday, June 17, 2004 2:37 PM To: Piet De Jong Cc: cvsspam-devel@lists.badgers-in-foil.co.uk Subject: Re: [cvsspam-devel] WinCVS Piet De Jong wrote: > I have cvsspam working fine when I do a commit through an ssh session, > using the 'cvs commit ' - command. I receive email etc. > > However I mainly use a front-end called wincvs from my develop > station, running on XP. When I do a commit, the mail does not get > send. I have several people here using wincvs frontend and they are generating messages just as do the regular command-line users. I can't see why there would be any difference - are you all using the same access mechanism (eg. :pserver: or whatever)? Maybe wincvs has an option to not execute scripts on the server side (I believe there is a commandline option for this as well). You'd have to hunt around in the preferences options I guess. -Ralph _______________________________________________ cvsspam-devel mailing list cvsspam-devel@lists.badgers-in-foil.co.uk http://lists.badgers-in-foil.co.uk/mailman/listinfo/cvsspam-devel From marc at datacodex.com Wed Jun 23 03:12:36 2004 From: marc at datacodex.com (Marc Wilson) Date: Wed, 23 Jun 2004 13:12:36 +1000 Subject: [cvsspam-devel] CVSSpam and Ruby on Windows Message-ID: <001201c458cf$f2441840$060a0a0a@TRAVELLER> Hi, I have set up CVSNT on my laptop running WinXP and have it working well. (Why you may ask, well I'm moving around to numerous client sites (none of whom have and CVS repos that I can use) so I am running CVS on my lappy for the work that I am doing for them.) I then installed the windows "version" of Ruby (http://rubyinstaller.rubyforge.org/wiki/wiki.pl?RubyInstaller) and it seems to work too. Then when I went for the tri-fecta of installing cvsspam I ran into some problems. Firstly, the Process.getpgrp method is not implemented on the windows runtime. Secondly, it picks up some syntax error in the find_data_dir method. There could be others but these are all I've found so far. Now I know that getting cvsspam running on Windows would not even be a blip on the priority radar, but would there be any chance that it would require some simple changes to get it working? I am not a ruby programmer, but if I were to poke around and try and get it working myself, would there be any pointers on where I should start? Cheers -Marc From dave at badgers-in-foil.co.uk Fri Jun 25 10:22:08 2004 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Fri, 25 Jun 2004 10:22:08 +0000 Subject: [cvsspam-devel] CVSSpam and Ruby on Windows In-Reply-To: <001201c458cf$f2441840$060a0a0a@TRAVELLER> References: <001201c458cf$f2441840$060a0a0a@TRAVELLER> Message-ID: <20040625102208.GA1232@vhost.badgers-in-foil.co.uk> On Wed, Jun 23, 2004 at 01:12:36PM +1000, Marc Wilson wrote: > Hi, > > I have set up CVSNT on my laptop running WinXP and have it working well. > (Why you may ask, well I'm moving around to numerous client sites (none > of whom have and CVS repos that I can use) so I am running CVS on my > lappy for the work that I am doing for them.) > > I then installed the windows "version" of Ruby > (http://rubyinstaller.rubyforge.org/wiki/wiki.pl?RubyInstaller) and it > seems to work too. > > Then when I went for the tri-fecta of installing cvsspam I ran into some > problems. I tried making CVSspam work under windows with the native Ruby port and CVSNT. I didn't spend enough effort get it to work though (see reason below). That particular install of w2k ate its own tail a while back, and I didn't bother backing up the few changes to CVSspam scripts :( > Firstly, the Process.getpgrp method is not implemented on the windows > runtime. Under linux, getpgrp is usually the PID of the CVS process handling this commit, and gives a handy value that's probably different from the value seen by any other commits happening concurrently to this one, but also the same between invocations of the different CVSspam scripts. (Did that make sense?) I think my solution to the problem was to just remove this from the data-dir template, and hope that two commits never 'collide' :) > Secondly, it picks up some syntax error in the find_data_dir method. > There could be others but these are all I've found so far. Was it 'missing data dir'? > Now I know that getting cvsspam running on Windows would not even be a > blip on the priority radar, but would there be any chance that it would > require some simple changes to get it working? > > I am not a ruby programmer, but if I were to poke around and try and get > it working myself, would there be any pointers on where I should start? The thing that stopped me getting any further with the port was the implementation of safer_popen() -- we get no fork/exec under windows :) This use of inter-process pipes aims to avoid log_accum.pl's approach of reading entire diff's into temporary variables. The nearest equivalent I could think up was to put the output of cvs diff into yet another tmp file, and process that. I moved on to other things before googling for other ideas, or trying to implement this one. FYI, Angus Mezick used the *Cygwin* port of Ruby to get CVSspam working with CVSNT. See this page on Matt Raible's site, http://www.raibledesigns.com/page/rd?anchor=problems_integrating_cvs_spam_and If you use both the Cygwin Ruby, and the Cygwin CVS, the script will probably work without changes. dave From dion.gillard at gmail.com Wed Jun 30 11:58:34 2004 From: dion.gillard at gmail.com (Dion Gillard) Date: Wed, 30 Jun 2004 21:58:34 +1000 Subject: [cvsspam-devel] CVSSpam and CVSNT Message-ID: I'm trying to get CVSSpam set up with CVSNT. I've tried it with ruby181-13.exe and get an error saying getpgrp is not implemented. I've tried it with ruby that comes with cygwin (ruby 1.8.1 (2003-12-25) [i386-cygwin]) and it fails with errors about the temporary directory. Is there a preferred version of ruby to use on win32?