From dave at badgers-in-foil.co.uk Mon Oct 3 12:46:18 2005 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Mon Oct 3 12:46:31 2005 Subject: [cvsspam-devel] strange error in collect_diffs.rb In-Reply-To: <438949c0509291231108f448a@mail.gmail.com> References: <438949c05092723312ef77ef9@mail.gmail.com> <20050928094922.GA4465@badgers-in-foil.co.uk> <438949c0509281029c16c88e@mail.gmail.com> <20050929090022.GA19171@badgers-in-foil.co.uk> <438949c050929084128e676b4@mail.gmail.com> <20050929160254.GA23847@badgers-in-foil.co.uk> <438949c0509291231108f448a@mail.gmail.com> Message-ID: <20051003124618.GA15895@badgers-in-foil.co.uk> On Thu, Sep 29, 2005 at 03:31:28PM -0400, Andy Crain wrote: > Hi David, > > > It's probably a bad assumption on the part of CVSspam. When invoking > > sendmail, CVSspam passes the options '-t' and '-oi'. I guess your > > version doesn't like one of them (probably -oi). > > > > Maybe you could look at the docs for you sendmail and edit the class > > SendmailMailer in cvsspam.rb to suit? > > Ta da! That did it. Thanks. > > crain:/$ echo test | /usr/sbin/sendmail -t -oi my_email@address.com > usage: /usr/sbin/sendmail [-f] [-t] [-s] > [-T] [-v] [addr > ess ...] > crain:/$ echo test | /usr/sbin/sendmail -oi -t my_email@address.com > usage: /usr/sbin/sendmail [-f] [-t] [-s] > [-T] [-v] [addr > ess ...] > crain:/$ echo test | /usr/sbin/sendmail -t my_email@address.com > crain:/$ Hmmm. FYI, here's the discussion around the time when '-oi' was added: http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/2004-October/000216.html I guess we should go back to implementing this in CVSspam, if it's required for portability between sendmail versions. dave -- http://david.holroyd.me.uk/ From dave at badgers-in-foil.co.uk Mon Oct 3 12:52:23 2005 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Mon Oct 3 12:52:26 2005 Subject: [cvsspam-devel] Reducing the size of emails In-Reply-To: <9BD5776ED7344C4AA6AE50285E77A1E3096656AA@exchny41.ny.ssmb.com> References: <9BD5776ED7344C4AA6AE50285E77A1E3096656AA@exchny41.ny.ssmb.com> Message-ID: <20051003125223.GB15895@badgers-in-foil.co.uk> Hi, On Fri, Sep 30, 2005 at 04:32:39PM -0400, Rafkind, Jonathan [IT] wrote: > Hm, maybe I spoke to soon. I see the limit of the diffs is 100k but > the email itself is much bigger because of the HTML tags. I will > reduce the size further to make emails smaller. Do you see a message at the bottom of the email warning you that the message got truncated? Unfortunately, this setting doesn't impose a hard limit on the size of the email, since for various not-very-good implementation reasons, the size of the index at the top of the message is not counted, and we allow the last diff in the message to appear in full, rather than chopping off the second half. If you think there's still an issue, even taking the above points into account, maybe you could forward one of your example messages as an attachment? dave -- http://david.holroyd.me.uk/ From dave at badgers-in-foil.co.uk Mon Oct 3 14:30:26 2005 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Mon Oct 3 14:30:35 2005 Subject: [cvsspam-devel] Re: inline style In-Reply-To: <438949c0509291527540206b0@mail.gmail.com> References: <438949c050929140184aed0d@mail.gmail.com> <438949c0509291527540206b0@mail.gmail.com> Message-ID: <20051003143025.GC15895@badgers-in-foil.co.uk> On Thu, Sep 29, 2005 at 06:27:25PM -0400, Andy Crain wrote: > > Would it be possible to send email with inline style, or at least an > > option to send inline? I ask because I have several users using > > webmail clients, which are stripping off the head, including the style > > declarations, as well as removing class and id attributes from tags. > > The only solution I can find [1] [2] is to use inline style. > > FWIW, attached is a patch adding inline style to the generated html. > I'm not a ruby coder, so there's a chance I've missed something, but > it works for me. Colorized diffs in webmail, woo hoo! I hate to say no to perfectly good code, but I'm not convinced that CVSspam should be making such great efforts to support the less capable MUAs out there. The intention has always been to support as broad a range of CSS capable clients as possible, and to try and avoid breaking horribly in things that at least support HTML minus CSS. Are there any specific areas where the formatting is just plain wrong in your target mail clients (other than simply missing font/colour style)? Maybe there are some simpler fixes that could be deployed for the individual b0rkage. I do appreciate your efforts to reasearch and implement this! dave -- http://david.holroyd.me.uk/ From newslogic at gmail.com Mon Oct 3 16:33:02 2005 From: newslogic at gmail.com (Andy Crain) Date: Mon Oct 3 16:33:45 2005 Subject: [cvsspam-devel] Re: inline style In-Reply-To: <20051003143025.GC15895@badgers-in-foil.co.uk> References: <438949c050929140184aed0d@mail.gmail.com> <438949c0509291527540206b0@mail.gmail.com> <20051003143025.GC15895@badgers-in-foil.co.uk> Message-ID: <438949c0510030933v21f05e9bq2e5d07b55fb5fbf4@mail.gmail.com> Hi Dave, > I hate to say no to perfectly good code, but I'm not convinced that > CVSspam should be making such great efforts to support the less capable > MUAs out there. No problem, I'd probably do the same. It is a pretty ugly hack, but in my case I didn't have much choice. > Are there any specific areas where the formatting is just plain wrong in > your target mail clients (other than simply missing font/colour style)? > Maybe there are some simpler fixes that could be deployed for the > individual b0rkage. Nope, as I recall everything came out fine, it just didn't get the nice, colorized styling. > I do appreciate your efforts to reasearch and implement this! No problem. Thanks for the great code. Andy From jonathan.rafkind at citigroup.com Mon Oct 3 16:37:32 2005 From: jonathan.rafkind at citigroup.com (Rafkind, Jonathan [IT]) Date: Mon Oct 3 16:39:28 2005 Subject: [cvsspam-devel] Reducing the size of emails Message-ID: <9BD5776ED7344C4AA6AE50285E77A1E3096656B1@exchny41.ny.ssmb.com> At the bottom of one of my large emails I get [truncated at 1000 lines; 3747 more skipped] [Reached 130876 bytes of diffs. Since the limit is about 102400 bytes, a further 1005176 were skipped.] The size of the email was 139kb. I changed the limit to 50k so the size of future emails should be somewhere around 60k I imagine. This is reasonable enough. -----Original Message----- From: cvsspam-devel-bounces@lists.badgers-in-foil.co.uk [mailto:cvsspam-devel-bounces@lists.badgers-in-foil.co.uk]On Behalf Of David Holroyd Sent: Monday, October 03, 2005 8:52 AM To: cvsspam-devel@lists.badgers-in-foil.co.uk Subject: Re: [cvsspam-devel] Reducing the size of emails Hi, On Fri, Sep 30, 2005 at 04:32:39PM -0400, Rafkind, Jonathan [IT] wrote: > Hm, maybe I spoke to soon. I see the limit of the diffs is 100k but > the email itself is much bigger because of the HTML tags. I will > reduce the size further to make emails smaller. Do you see a message at the bottom of the email warning you that the message got truncated? Unfortunately, this setting doesn't impose a hard limit on the size of the email, since for various not-very-good implementation reasons, the size of the index at the top of the message is not counted, and we allow the last diff in the message to appear in full, rather than chopping off the second half. If you think there's still an issue, even taking the above points into account, maybe you could forward one of your example messages as an attachment? dave -- http://david.holroyd.me.uk/ _______________________________________________ cvsspam-devel mailing list cvsspam-devel@lists.badgers-in-foil.co.uk http://lists.badgers-in-foil.co.uk/mailman/listinfo/cvsspam-devel From dirty at apple.com Thu Oct 13 10:37:52 2005 From: dirty at apple.com (Cameron Esfahani) Date: Thu Oct 13 12:13:32 2005 Subject: [cvsspam-devel] Bug with binary file diffs? Message-ID: <87C576F0-C072-44A0-BBDA-37E43EA9CBF9@apple.com> Hi, I'm having some trouble with cvsspam and I think I found a small bug. If I have a binary file, then the only output of svnlook diff after the line of equals is "(Binary files differ)". The state machine in read_modified_diff doesn't seem to handle it... Here is the stack trace: svnlook: Write error: Broken pipe ./svn_post_commit_hook.rb:155:in `assert_next': unexpected "(Binary files differ)\n" (RuntimeError) from ./svn_post_commit_hook.rb:164:in `read_modified_diff' from ./svn_post_commit_hook.rb:278:in `process_svnlook_diff' from ./svn_post_commit_hook.rb:274:in `svnlook' from ./svn_post_commit_hook.rb:94:in `safer_popen' from ./svn_post_commit_hook.rb:45:in `popen' from ./svn_post_commit_hook.rb:45:in `safer_popen' from ./svn_post_commit_hook.rb:94:in `svnlook' from ./svn_post_commit_hook.rb:274:in `process_svnlook_diff' from ./svn_post_commit_hook.rb:299:in `process_commit' from ./svn_post_commit_hook.rb:297:in `open' from ./svn_post_commit_hook.rb:297:in `process_commit' from ./svn_post_commit_hook.rb:307:in `main' from ./svn_post_commit_hook.rb:313 Cameron Esfahani dirty@apple.com "It is the spirit and not the form of law that keeps justice alive." Earl Warren From dave at badgers-in-foil.co.uk Thu Oct 13 13:17:00 2005 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Thu Oct 13 13:17:08 2005 Subject: [cvsspam-devel] Bug with binary file diffs? In-Reply-To: <87C576F0-C072-44A0-BBDA-37E43EA9CBF9@apple.com> References: <87C576F0-C072-44A0-BBDA-37E43EA9CBF9@apple.com> Message-ID: <20051013131659.GD19187@badgers-in-foil.co.uk> On Thu, Oct 13, 2005 at 03:37:52AM -0700, Cameron Esfahani wrote: > I'm having some trouble with cvsspam and I think I found a small bug. > > If I have a binary file, then the only output of svnlook diff after > the line of equals is "(Binary files differ)". The state machine in > read_modified_diff doesn't seem to handle it... I may have mentioned something about this code eating your pets? ;) Well, anyway, update to the latest code in svn. I've just fixed this problem for modifications to binary files, though additions / removals will probably still fail... dave -- http://david.holroyd.me.uk/ From rmccullough at rightnow.com Mon Oct 31 18:37:47 2005 From: rmccullough at rightnow.com (McCullough, Ryan) Date: Mon Oct 31 22:51:43 2005 Subject: [cvsspam-devel] Feature requests Message-ID: <72B05D2430A134479CE88C7C4BF750B3D59B5E@RNT-BOZ-0201.corp.rightnow.com> I have 2 feature requests for cvsspam. 1) the Subject is currently formatted as [CVS ]. It would be nice if there was an option for the common directory prefix to be in the subject. Like '[CVS ]'. 2) When using a frontend like cvsweb, the files should be able to be linked. Right now there are 3 links. 1 to the previous version, 1 to the current version and 1 to diff the 2. The file itself should be linked to the cvs log page for cvsweb: http:///cgi-bin/cvsweb.cgi/repo// Thanks. \\ \|/ // \\ _|_ // ( o o ) ===========oOOo-(_)-oOOo=========== Ryan McCullough SQA Engineer RightNow Technologies 406-556-3162 mailto:rmccullough@rightnow.com ===================Oooo============ oooO ( ) ( ) ) / \ ( (_/ \_)