From joe at eiler.net Sun Jul 2 21:00:16 2006 From: joe at eiler.net (Joe Eiler) Date: Sun Jul 2 21:04:24 2006 Subject: [cvsspam-devel] Minor fix for subversion property handling Message-ID: We shouldn't die if the user does a property change where the property has no value. This problem was discovered by someone who had screwed up their auto-props setting in .subversion/config. Joe Oh, and if you see an authorization message in your log that was my fault, I thought I was in my local repo and not the real one. --- svn_post_commit_hook.rb (revision 246) +++ svn_post_commit_hook.rb (working copy) @@ -238,7 +238,7 @@ end def assert_prop_match(a, b) - if a != b + if b != nil && a != b raise "property mismatch: #{a.inspect}!=#{b.inspect}" end end From dave at badgers-in-foil.co.uk Tue Jul 4 19:23:26 2006 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Tue Jul 4 19:23:31 2006 Subject: [cvsspam-devel] Minor fix for subversion property handling In-Reply-To: References: Message-ID: <20060704192325.GA10496@badgers-in-foil.co.uk> On Sun, Jul 02, 2006 at 02:00:16PM -0700, Joe Eiler wrote: > We shouldn't die if the user does a property change where the property > has no value. This problem was discovered by someone who had screwed up > their auto-props setting in .subversion/config. Do you know what it was in their config that caused the problem? I'd like to try to add a test case to reproduce this problem. Thanks for identifying this bug! dave -- http://david.holroyd.me.uk/ From joe at eiler.net Wed Jul 5 02:24:54 2006 From: joe at eiler.net (Joe Eiler) Date: Wed Jul 5 02:26:32 2006 Subject: [cvsspam-devel] Minor fix for subversion property handling Message-ID: I believe it was an auto-prop for svn_keywords with no value. So somehting like this... *.c = svn:eol-style=native;svn:keywords When a file was added, the diff showed a property change but the propget call did not return anything. Joe > On Sun, Jul 02, 2006 at 02:00:16PM -0700, Joe Eiler wrote: > > We shouldn't die if the user does a property change where the property > > has no value. This problem was discovered by someone who had screwed up > > their auto-props setting in .subversion/config. > > Do you know what it was in their config that caused the problem? I'd > like to try to add a test case to reproduce this problem. > > > Thanks for identifying this bug! > dave > > -- > http://david.holroyd.me.uk/ > > _______________________________________________ > cvsspam-devel mailing list > cvsspam-devel@lists.badgers-in-foil.co.uk > http://lists.badgers-in-foil.co.uk/mailman/listinfo/cvsspam-devel > > Joe Eiler joe@eiler.net (home) 763.577.1786 (cell) 763.370.0524 -- From rmccullough at rightnow.com Wed Jul 5 15:42:08 2006 From: rmccullough at rightnow.com (McCullough, Ryan) Date: Wed Jul 5 15:43:18 2006 Subject: [cvsspam-devel] is the web repository up to date? Message-ID: <754F650D83706542B09D4AA7A201B2EA427B75@RNT-BOZ-0201.corp.rightnow.com> Skipped content of type multipart/alternative-------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3038 bytes Desc: not available Url : http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/attachments/20060705/51f6085f/smime.bin From dave at badgers-in-foil.co.uk Thu Jul 6 08:05:25 2006 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Thu Jul 6 08:05:39 2006 Subject: [cvsspam-devel] is the web repository up to date? In-Reply-To: <754F650D83706542B09D4AA7A201B2EA427B75@RNT-BOZ-0201.corp.rightnow.com> References: <754F650D83706542B09D4AA7A201B2EA427B75@RNT-BOZ-0201.corp.rightnow.com> Message-ID: <20060706080525.GA26309@badgers-in-foil.co.uk> On Wed, Jul 05, 2006 at 09:42:08AM -0600, McCullough, Ryan wrote: > I was wondering if the repository at > http://svn.badgers-in-foil.co.uk/cvsspam/trunk/ is kept up to date with the > patches sent to the mailing list? Yes, it should be. Subversion stuff will end up over here instead, though: http://svn.badgers-in-foil.co.uk/cvsspam/branches/svn_support/ ta, dave -- http://david.holroyd.me.uk/ From dave at badgers-in-foil.co.uk Thu Jul 6 08:47:41 2006 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Thu Jul 6 08:47:55 2006 Subject: [cvsspam-devel] Minor fix for subversion property handling In-Reply-To: References: Message-ID: <20060706084741.GB26309@badgers-in-foil.co.uk> On Tue, Jul 04, 2006 at 07:24:54PM -0700, Joe Eiler wrote: > I believe it was an auto-prop for svn_keywords with no value. > > So somehting like this... > *.c = svn:eol-style=native;svn:keywords > > When a file was added, the diff showed a property change but the > propget call did not return anything. Ok, I've comitted a fix for this that gets around the problem in a slightly different way (I modified the caller of assert_prop_match(), rather than that method itself). I've also added a basic smoketest for this situation in 'svntestcases/test.rb'. ta, dave -- http://david.holroyd.me.uk/ From joe at eiler.net Thu Jul 6 20:10:16 2006 From: joe at eiler.net (Joe Eiler) Date: Thu Jul 6 20:11:21 2006 Subject: [cvsspam-devel] Minor fix for subversion property handling Message-ID: Cool, the caller was the munch routine correct? I thought about putting a check in there at first but on a whim I decided to go to the lowest common denominator. Thanks for getting a fix in. Joe > On Tue, Jul 04, 2006 at 07:24:54PM -0700, Joe Eiler wrote: > > I believe it was an auto-prop for svn_keywords with no value. > > > > So somehting like this... > > *.c = svn:eol-style=native;svn:keywords > > > > When a file was added, the diff showed a property change but the > > propget call did not return anything. > > Ok, I've comitted a fix for this that gets around the problem in a > slightly different way (I modified the caller of assert_prop_match(), > rather than that method itself). > > I've also added a basic smoketest for this situation in > 'svntestcases/test.rb'. > > > ta, > dave > > -- > http://david.holroyd.me.uk/ > > _______________________________________________ > cvsspam-devel mailing list > cvsspam-devel@lists.badgers-in-foil.co.uk > http://lists.badgers-in-foil.co.uk/mailman/listinfo/cvsspam-devel > > Joe Eiler joe@eiler.net (home) 763.577.1786 (cell) 763.370.0524 --