From glen at delfi.ee  Wed Mar  1 22:59:52 2006
From: glen at delfi.ee (Elan =?iso-8859-1?q?Ruusam=E4e?=)
Date: Wed Mar  1 23:00:44 2006
Subject: [cvsspam-devel] eventum issue xxx linking
Message-ID: <200603020059.52465.glen@delfi.ee>

hi

please consider adding the patch [1]  to support 'issue \d+' pattern 
recognizing to link to Eventum Issue / Bug tracking system [2]

[1] http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/cvsspam-issue.patch
[2] http://eventum.mysql.org/

-- 
glen

From glen at delfi.ee  Wed Mar  1 23:26:57 2006
From: glen at delfi.ee (Elan =?iso-8859-13?q?Ruusam=E4e?=)
Date: Wed Mar  1 23:29:57 2006
Subject: [cvsspam-devel] repository path
In-Reply-To: <20060223225729.GA20673@badgers-in-foil.co.uk>
References: <200602221142.20201.glen@delfi.ee>
	<200602231742.40054.glen@delfi.ee>
	<20060223225729.GA20673@badgers-in-foil.co.uk>
Message-ID: <200603020126.57402.glen@delfi.ee>

On Friday 24 February 2006 00:57, David Holroyd wrote:
> On Thu, Feb 23, 2006 at 05:42:39PM +0200, Elan Ruusam?e wrote:
> > On Thursday 23 February 2006 11:05, David Holroyd wrote:
> > > Do you mean you'd like access to the common path prefix (under the
> > > CVSROOT) shared by all committed files (i.e. like the folder named at
> > > the very top of the CVSspam email "Commit in XXX" message)?
> >
> > yes. exactly. it's even better that i wanted, as i didn't think of
> > commited files accross different module paths.
>
> How about the attached patch?
found one bug. the first component of path is present twice. 
let's say, you commit in CVSROOT, then the header will be:

X-CVSspam-Module-Path: /CVSROOT/CVSROOT

so perhaps just have there:
mod << "#{rep.common_prefix}"

-- 
glen

From lasterra at javahispano.org  Sun Mar  5 17:24:09 2006
From: lasterra at javahispano.org (Enrique Rodriguez Lasterra)
Date: Sun Mar  5 17:25:23 2006
Subject: [cvsspam-devel] HTML with gmail and evolution
Message-ID: <1141579449.13538.4.camel@localhost>

I installed CVSSpam but i cannot see coloured sintax on gmail and
evolution. I see the html format used by cvsspam is totally perfect but
web clients remove <style> tags and evolution seems that doesn't support
styles.

are you thinking in change the html format to support more reader
clients? 
-- 
_______________________________
Enrique Rodriguez Lasterra
lasterra AT javahispano DOT org
http://www.javahispano.org
Asociaci?n sin ?nimo de lucro sobre java
Spanish non profit association about java


From dave at badgers-in-foil.co.uk  Wed Mar  8 20:59:48 2006
From: dave at badgers-in-foil.co.uk (David Holroyd)
Date: Wed Mar  8 20:59:51 2006
Subject: [cvsspam-devel] repository path
In-Reply-To: <200603020126.57402.glen@delfi.ee>
References: <200602221142.20201.glen@delfi.ee>
	<200602231742.40054.glen@delfi.ee>
	<20060223225729.GA20673@badgers-in-foil.co.uk>
	<200603020126.57402.glen@delfi.ee>
Message-ID: <20060308205948.GB15357@badgers-in-foil.co.uk>

On Thu, Mar 02, 2006 at 01:26:57AM +0200, Elan Ruusam?e wrote:
> On Friday 24 February 2006 00:57, David Holroyd wrote:
> > How about the attached patch?
> found one bug. the first component of path is present twice. 
> let's say, you commit in CVSROOT, then the header will be:
> 
> X-CVSspam-Module-Path: /CVSROOT/CVSROOT
> 
> so perhaps just have there:
> mod << "#{rep.common_prefix}"

I've committed that change.

Thanks!
dave

-- 
http://david.holroyd.me.uk/

From joe at eiler.net  Wed Mar  1 22:28:15 2006
From: joe at eiler.net (Joe Eiler)
Date: Wed Mar  8 21:01:11 2006
Subject: [cvsspam-devel] CVSspam for subversion
Message-ID: <E1FEZnq-0004JW-K3@host01.ipowerweb.com>

I did a little hacking on the subversion branch of cvsspam.

It is far from finished but is working good enough for me right now.
Since I may not work on it in the near future I thought I would push
what I have upstream in case anyone else can make use out of it.

Attached is a patch against 
http://svn.badgers-in-foil.co.uk/cvsspam/branches/svn_support



-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 15137 bytes
Desc: not available
Url : http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/attachments/20060301/181765eb/attachment.bin
From steve.woodcock at gmail.com  Tue Mar  7 17:46:12 2006
From: steve.woodcock at gmail.com (Steve Woodcock)
Date: Wed Mar  8 21:01:14 2006
Subject: [cvsspam-devel] CVSweb redirect patch
Message-ID: <ff68c4ad0603070946k11303670lcdd89c6783744958@mail.gmail.com>

Hi,

This patch to 0.2.12 avoids a redirect which CVSweb issues when the
directory doesn't end with a slash. This redirect caused us a problem
because CVSweb doesn't issue a fully qualified Location: header and
our web server replaces it (I think) with what it thinks is the fully
qualified location, but gets it wrong because we've got a proxy in the
way. Anyway, it'll minutely speed up clicking on the links due to the
saved round trip.

Regards, Steve Woodcock

--- CVSROOT/cvsspam.rb	2006/03/07 15:50:57	1.4
+++ CVSROOT/cvsspam.rb	2006/03/07 16:57:56	1.6
@@ -767,9 +767,9 @@ end
 class CVSwebFrontend < WebFrontend
   def path_url(path, tag)
     if tag == nil
-      add_repo(@base_url + urlEncode(path))
+      add_repo(@base_url + urlEncode(path) + "/")
     else
-      add_repo("#{@base_url}#{urlEncode(path)}?only_with_tag=#{urlEncode(tag)}")
+      add_repo("#{@base_url}#{urlEncode(path)}/?only_with_tag=#{urlEncode(tag)}")
     end
   end

From dave at badgers-in-foil.co.uk  Wed Mar  8 21:05:28 2006
From: dave at badgers-in-foil.co.uk (David Holroyd)
Date: Wed Mar  8 21:05:31 2006
Subject: [cvsspam-devel] eventum issue xxx linking
In-Reply-To: <200603020059.52465.glen@delfi.ee>
References: <200603020059.52465.glen@delfi.ee>
Message-ID: <20060308210528.GC15357@badgers-in-foil.co.uk>

On Thu, Mar 02, 2006 at 12:59:52AM +0200, Elan Ruusam?e wrote:
> please consider adding the patch [1]  to support 'issue \d+' pattern 
> recognizing to link to Eventum Issue / Bug tracking system [2]
> 
> [1] http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/cvsspam-issue.patch
> [2] http://eventum.mysql.org/

Patch applied, with thanks!


dave

-- 
http://david.holroyd.me.uk/

From dave at badgers-in-foil.co.uk  Wed Mar  8 21:18:51 2006
From: dave at badgers-in-foil.co.uk (David Holroyd)
Date: Wed Mar  8 21:18:55 2006
Subject: [cvsspam-devel] HTML with gmail and evolution
In-Reply-To: <1141579449.13538.4.camel@localhost>
References: <1141579449.13538.4.camel@localhost>
Message-ID: <20060308211851.GD15357@badgers-in-foil.co.uk>

On Sun, Mar 05, 2006 at 06:24:09PM +0100, Enrique Rodriguez Lasterra wrote:
> I installed CVSSpam but i cannot see coloured sintax on gmail and
> evolution. I see the html format used by cvsspam is totally perfect but
> web clients remove <style> tags and evolution seems that doesn't support
> styles.
> 
> are you thinking in change the html format to support more reader
> clients? 

Getting anything but the simplest layout to look 'right' across all mail
clients that support HTML is impossible.  Given that, I decided that I
would wait for mail clients to catch up with modern standards, rather
than putting huge efforts into getting the HTML to work everywhere :)

If CVSspam were better designed, you could hack up your own templates
for the messages.  Unfortunately, there is no clean way to do that right
now :(

Does anyone know of a way to get GMail / Evolution to accept the CSS, or
maybe improve the way that message formatting 'degrades' in these mail
readers?


ta,
dave

-- 
http://david.holroyd.me.uk/

From dave at badgers-in-foil.co.uk  Wed Mar  8 21:25:16 2006
From: dave at badgers-in-foil.co.uk (David Holroyd)
Date: Wed Mar  8 21:25:20 2006
Subject: [cvsspam-devel] CVSweb redirect patch
In-Reply-To: <ff68c4ad0603070946k11303670lcdd89c6783744958@mail.gmail.com>
References: <ff68c4ad0603070946k11303670lcdd89c6783744958@mail.gmail.com>
Message-ID: <20060308212516.GE15357@badgers-in-foil.co.uk>

On Tue, Mar 07, 2006 at 05:46:12PM +0000, Steve Woodcock wrote:
> This patch to 0.2.12 avoids a redirect which CVSweb issues when the
> directory doesn't end with a slash. This redirect caused us a problem
> because CVSweb doesn't issue a fully qualified Location: header and
> our web server replaces it (I think) with what it thinks is the fully
> qualified location, but gets it wrong because we've got a proxy in the
> way. Anyway, it'll minutely speed up clicking on the links due to the
> saved round trip.

Great!  I have applied the patch, and it will be available in the next
release of CVSspam.


thank you,
dave

-- 
http://david.holroyd.me.uk/

From dave at badgers-in-foil.co.uk  Wed Mar  8 21:39:36 2006
From: dave at badgers-in-foil.co.uk (David Holroyd)
Date: Wed Mar  8 21:39:44 2006
Subject: [cvsspam-devel] CVSspam for subversion
In-Reply-To: <E1FEZnq-0004JW-K3@host01.ipowerweb.com>
References: <E1FEZnq-0004JW-K3@host01.ipowerweb.com>
Message-ID: <20060308213935.GF15357@badgers-in-foil.co.uk>

On Wed, Mar 01, 2006 at 02:28:15PM -0800, Joe Eiler wrote:
> I did a little hacking on the subversion branch of cvsspam.
> 
> It is far from finished but is working good enough for me right now.
> Since I may not work on it in the near future I thought I would push
> what I have upstream in case anyone else can make use out of it.

That's fantastic!  Unfortunately, the patch doesn't apply cleanly (I
think you made some tiny modifications to the 'original' version you are
diffing against).

If you have time, could you create another patch?  If not, I can
probably hand merge the few bits it has issue with in my next allocation
of hack-time.


thanks for your work!
dave


-- 
http://david.holroyd.me.uk/

From joe at eiler.net  Thu Mar  9 03:55:14 2006
From: joe at eiler.net (Joe Eiler)
Date: Thu Mar  9 03:56:29 2006
Subject: [cvsspam-devel] CVSspam for subversion
Message-ID: <E1FHCF6-0000is-TK@host01.ipowerweb.com>

Ooops, sorry, I merged trunk into the subversion branch.  

I have split the changes into two patches (and also ripped out my config
changes).

The first "trunk2svn" patch merges the changes from trunk into svn_support.

The second "svn_support" patch adds the stuff related to subversion.

If you apply them in order everything goes in clean.
If you just try to apply the svn_support.patch, one hunk fails in cvsspam.rb


Joe
-- 
Dealing with failure is easy: work hard to improve.
Success is also easy to handle: you've solved the
wrong problem. Work hard to improve. -- Bob Wilcox

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 6472 bytes
Desc: not available
Url : http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/attachments/20060308/57968b34/attachment-0002.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 14884 bytes
Desc: not available
Url : http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/attachments/20060308/57968b34/attachment-0003.bin
From dave at badgers-in-foil.co.uk  Mon Mar 13 08:40:10 2006
From: dave at badgers-in-foil.co.uk (David Holroyd)
Date: Mon Mar 13 08:40:31 2006
Subject: [cvsspam-devel] CVSspam for subversion
In-Reply-To: <E1FHCF6-0000is-TK@host01.ipowerweb.com>
References: <E1FHCF6-0000is-TK@host01.ipowerweb.com>
Message-ID: <20060313084008.GA20464@badgers-in-foil.co.uk>

On Wed, Mar 08, 2006 at 07:55:14PM -0800, Joe Eiler wrote:
> Ooops, sorry, I merged trunk into the subversion branch.  
> 
> I have split the changes into two patches (and also ripped out my config
> changes).
> 
> The first "trunk2svn" patch merges the changes from trunk into svn_support.
> 
> The second "svn_support" patch adds the stuff related to subversion.
> 
> If you apply them in order everything goes in clean.
> If you just try to apply the svn_support.patch, one hunk fails in cvsspam.rb

I've applied your patches, and committed the changes.  Many thanks!

I will deploy this on one of the personal projects I'm currently hosting
in Subversion for some testing.


dave

-- 
http://david.holroyd.me.uk/

From martin.morissette at gmail.com  Thu Mar 30 07:36:27 2006
From: martin.morissette at gmail.com (Martin Morissette)
Date: Thu Mar 30 07:37:12 2006
Subject: [cvsspam-devel] HTML Formatting
Message-ID: <e9b0429d0603292336s781983d3wd065873a8b48536c@mail.gmail.com>

Hi all,

I just installed cvsspam and I have to say it is really great. We replaced
an homebrewed similar product with yours and it works like a charm (almost,
otherwise I would not be posting this message ;-)

My problem is with the html formatting when sending a message. The message
that is sent seems to be correctly formatted but the (funky) colors don't
show up. This problem was encountered under gmail (using Camino, Firefox and
Safari under Mac OS X). The weird thing is, if I copy the original message's
body to a html file and display it with any of my browsers, the colors show
up nicely.

Also, I just tried sending the message to my Mail client and the colors
appear just fine! So I guess we can conclude that only gmail has that
problem. The problem is that most of the team uses gmail, so... any
suggestions would be greatly appreciated!

Does any one have any suggestions or ideas? Anything I could try?

Thank you for your help
Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/attachments/20060329/e699cd5f/attachment.htm
From glen at starretthome.net  Thu Mar 30 14:52:18 2006
From: glen at starretthome.net (Glen Starrett)
Date: Thu Mar 30 14:52:53 2006
Subject: [cvsspam-devel] HTML Formatting
In-Reply-To: <e9b0429d0603292336s781983d3wd065873a8b48536c@mail.gmail.com>
References: <e9b0429d0603292336s781983d3wd065873a8b48536c@mail.gmail.com>
Message-ID: <442BF0A2.4090301@starretthome.net>

Martin Morissette wrote:

> Also, I just tried sending the message to my Mail client and the 
> colors appear just fine! So I guess we can conclude that only gmail 
> has that problem. The problem is that most of the team uses gmail, 
> so... any suggestions would be greatly appreciated!
>
> Does any one have any suggestions or ideas? Anything I could try?


The suggestion would be to not use a HTML mail client.  Gmail (and 
Yahoo, etc.) don't display the colors correctly because I believe they 
don't use the CSS properly (probably to stop some CSS from messing up 
their framing webpage).

This came up recently on the list, look through the archives.

Regards,

Glen Starrett