From dave at badgers-in-foil.co.uk Tue Nov 28 21:48:40 2006 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Tue Nov 28 21:48:42 2006 Subject: [cvsspam-devel] Mailing list issues Message-ID: <20061128214840.GC21634@badgers-in-foil.co.uk> I got bored deleleting spam from the cvsspam-devel mailing list moderation queue a while back and it appears that this has caused problems for people trying to post to the list (and also, because I now notice that there are several unanswered emails on the online archive). I've just deleted a few hundred items, so hopefully this message will get though... dave -- http://david.holroyd.me.uk/ From dave at badgers-in-foil.co.uk Tue Nov 28 22:44:25 2006 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Tue Nov 28 22:44:36 2006 Subject: [cvsspam-devel] patch for incorrect handling of Binary adds (SVN) In-Reply-To: <44DA2CC3.90907@fullsix.com> References: <44DA2CC3.90907@fullsix.com> Message-ID: <20061128224425.GD21634@badgers-in-foil.co.uk> Hi there, On Wed, Aug 09, 2006 at 08:43:15PM +0200, Renaud Bruyeron wrote: > The following patch against > http://svn.badgers-in-foil.co.uk/cvsspam/branches/svn_support > corrects an issue in svnspam when the revision contains new binary files. Thanks! I've applied the patch, and included addition of a binady file in the 'smoke tests' in the svntestcases dir. Sorry about the delay in replying :) dave -- http://david.holroyd.me.uk/ From dave at badgers-in-foil.co.uk Tue Nov 28 22:49:57 2006 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Tue Nov 28 22:49:59 2006 Subject: [cvsspam-devel] tagging hooks for use with cvsspam In-Reply-To: References: Message-ID: <20061128224957.GE21634@badgers-in-foil.co.uk> On Wed, Aug 16, 2006 at 02:10:21PM -0400, Haroon Rafique wrote: > Secondly, I have developed some hooks for use with taginfo/posttag which > allow notifications whenever tagging events happen. If there is any > interest, then I can either post to the mailing list (if list accepts > attachments) or publish on a website for download. > > Caveats: > > * This is my first attempt at ruby ever. I decided to write in ruby since > I was really duplicating most of the logic already present in the > existing scripts. So please be gentle if and when you do provide > feedback. > > * I am using cvs 1.12.12. From what I understand posttag hook was only > added in 1.12.10. My hooks will *NOT* work with cvs 1.11.x. > Theoretically these hooks should work with 1.12.10+ > > * You will get one email for each tagging event performed with a "cvs tag" > command. However, when using a "cvs rtag" command (which I have never > used), I have been told that the sequence in which the taginfo and > posttag hooks run is once per directory. So you will get as many emails > as the number of involved directories (again, I haven't tried this with > "cvs rtag" - just speculating) Do your scripts use the same kind of logic as CVSspam's commit-processing, or did they make the tagging hooks a bit less odd? I've thought of having a cron job or background process of some sort to try and batch events where CVS simply just doesn't provide the info to link them as they happen (e.g. addition of directories, IIRC). I could never be bothered to implement that though. It would be great to see your work! Sorry about the slow reply! ta, dave -- http://david.holroyd.me.uk/ From dave at badgers-in-foil.co.uk Tue Nov 28 22:53:17 2006 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Tue Nov 28 22:53:19 2006 Subject: [cvsspam-devel] Ruby with CVS and Ext/Ssh protocol and world writable /tmp dir In-Reply-To: <30A5F9D51C0D9D47BD8D89C85B49E7003C8F3E@EVS2.corp.rightnow.com> References: <30A5F9D51C0D9D47BD8D89C85B49E7003C8F3E@EVS2.corp.rightnow.com> Message-ID: <20061128225317.GF21634@badgers-in-foil.co.uk> On Wed, Oct 18, 2006 at 02:04:57PM -0600, McCullough, Ryan wrote: > I am running a pserver on a machine, but I am also using ext protocol on it. > When I try to commit to a module using the ext protocol I get this message: > > In S:\sqabas32_ie7: "C:\Program Files\TortoiseCVS\cvs.exe" -q commit -m "fix > failing commit through ssh" TestAstrobot.rec > CVSROOT=:ext:********@********:/home/cvs > > Checking in TestAstrobot.rec; > /home/cvs/repo/rational/robot/sqabas32/TestAstrobot.rec,v <-- > TestAstrobot.rec > new revision: 1.1.2.5; previous revision: 1.1.2.4 > done > /usr/local/lib/cvsspam/collect_diffs.rb:65: warning: Insecure world writable > dir /tmp, mode 040777 > /usr/local/lib/cvsspam/collect_diffs.rb:65: warning: Insecure world writable > dir /tmp, mode 040777 > /usr/local/lib/cvsspam/collect_diffs.rb:314: warning: Insecure world > writable dir /tmp, mode 040777 > /usr/local/lib/cvsspam/cvsspam.rb:1820: warning: Insecure world writable dir > /tmp, mode 040777 > > Success, CVS operation completed It does still succeed and send the message though? What version of Ruby is installed on the CVS server? ta, dave -- http://david.holroyd.me.uk/ From dave at badgers-in-foil.co.uk Wed Nov 29 21:30:44 2006 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Wed Nov 29 21:31:01 2006 Subject: [cvsspam-devel] Ruby with CVS and Ext/Ssh protocol and worldwritable /tmp dir In-Reply-To: <30A5F9D51C0D9D47BD8D89C85B49E700522BE2@EVS2.corp.rightnow.com> References: <20061128225317.GF21634@badgers-in-foil.co.uk> <30A5F9D51C0D9D47BD8D89C85B49E700522BE2@EVS2.corp.rightnow.com> Message-ID: <20061129213043.GB15640@badgers-in-foil.co.uk> On Tue, Nov 28, 2006 at 05:41:33PM -0700, McCullough, Ryan wrote: > T rmccullough@bighorn:/{7}>ruby --version > ruby 1.8.3 (2005-09-21) [i686-linux] > > I don't remember if it fails or succeeds. I think it sends an email > for each individual file in the check-in. I think that the warnings are benign (though annoying). Their appearence should not effect the operation of CVSspam. Googling for that message, I've seen suggestions that the warning may not be produced in later releases of Ruby (the discussions are from around September 2006, so I don't know if a Ruby release with this fix is available yet). It may be possible to silence the warning with your current Ruby install by doing some shell-scripting to remove '.' from the path just before the hook-script is invoked. I'm not too sure though. Maybe something like, ^ PATH=/bin:/usr/bin /path/to/cvsspam.rb ... ?? I know that on most systems I use, '.' isn't in the path though, and if your system is the same, the above would make no difference :( > > In S:\sqabas32_ie7: "C:\Program Files\TortoiseCVS\cvs.exe" -q commit > > -m "fix failing commit through ssh" TestAstrobot.rec > > CVSROOT=:ext:********@********:/home/cvs > > > > Checking in TestAstrobot.rec; > > /home/cvs/repo/rational/robot/sqabas32/TestAstrobot.rec,v <-- > > TestAstrobot.rec new revision: 1.1.2.5; previous revision: 1.1.2.4 > > done > > /usr/local/lib/cvsspam/collect_diffs.rb:65: warning: Insecure world > > writable dir /tmp, mode 040777 > > /usr/local/lib/cvsspam/collect_diffs.rb:65: warning: Insecure world > > writable dir /tmp, mode 040777 > > /usr/local/lib/cvsspam/collect_diffs.rb:314: warning: Insecure world > > writable dir /tmp, mode 040777 > > /usr/local/lib/cvsspam/cvsspam.rb:1820: warning: Insecure world > > writable dir /tmp, mode 040777 > > > > Success, CVS operation completed ta, dave From dave at badgers-in-foil.co.uk Wed Nov 29 21:53:16 2006 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Wed Nov 29 21:53:21 2006 Subject: [cvsspam-devel] Ruby with CVS and Ext/Ssh protocol and worldwritable /tmp dir In-Reply-To: <30A5F9D51C0D9D47BD8D89C85B49E700522CE2@EVS2.corp.rightnow.com> References: <20061129213043.GB15640@badgers-in-foil.co.uk> <30A5F9D51C0D9D47BD8D89C85B49E700522CE2@EVS2.corp.rightnow.com> Message-ID: <20061129215316.GD15640@badgers-in-foil.co.uk> On Wed, Nov 29, 2006 at 02:45:20PM -0700, McCullough, Ryan wrote: > I believe it is in the path for my account, but cvs spam runs under the cvs > account. Why would it only do this with SSH/EXT Protocol though? What credentials do you use with SSH/EXT? If you use the CVS user's credentials, then I dunno what's up with that. If you use your personal credentials (and unless you've got CVS set up setuid/setgid to the cvs user), then in all likelehood you are actually executing the CVS server as yourself, rather than the cvs user. You could test that idea by enabling the CVSspam --debug flag and inspecting the files/folders that will then get left in /tmp. If they are owned by you, then you've found the problem :) > -----Original Message----- > From: David Holroyd [mailto:dave@badgers-in-foil.co.uk] > Sent: Wednesday, November 29, 2006 2:31 PM > To: McCullough, Ryan > Cc: cvsspam-devel@lists.badgers-in-foil.co.uk > Subject: Re: [cvsspam-devel] Ruby with CVS and Ext/Ssh protocol and > worldwritable /tmp dir > > On Tue, Nov 28, 2006 at 05:41:33PM -0700, McCullough, Ryan wrote: > > T rmccullough@bighorn:/{7}>ruby --version ruby 1.8.3 (2005-09-21) > > [i686-linux] > > > > I don't remember if it fails or succeeds. I think it sends an email > > for each individual file in the check-in. > > I think that the warnings are benign (though annoying). Their appearence > should not effect the operation of CVSspam. > > Googling for that message, I've seen suggestions that the warning may not be > produced in later releases of Ruby (the discussions are from around > September 2006, so I don't know if a Ruby release with this fix is available > yet). > > It may be possible to silence the warning with your current Ruby install by > doing some shell-scripting to remove '.' from the path just before the > hook-script is invoked. I'm not too sure though. Maybe something like, > > ^ PATH=/bin:/usr/bin /path/to/cvsspam.rb ... > > ?? > > I know that on most systems I use, '.' isn't in the path though, and if your > system is the same, the above would make no difference :( > > > > > In S:\sqabas32_ie7: "C:\Program Files\TortoiseCVS\cvs.exe" -q commit > > > -m "fix failing commit through ssh" TestAstrobot.rec > > > CVSROOT=:ext:********@********:/home/cvs > > > > > > Checking in TestAstrobot.rec; > > > /home/cvs/repo/rational/robot/sqabas32/TestAstrobot.rec,v <-- > > > TestAstrobot.rec new revision: 1.1.2.5; previous revision: 1.1.2.4 > > > done > > > /usr/local/lib/cvsspam/collect_diffs.rb:65: warning: Insecure world > > > writable dir /tmp, mode 040777 > > > /usr/local/lib/cvsspam/collect_diffs.rb:65: warning: Insecure world > > > writable dir /tmp, mode 040777 > > > /usr/local/lib/cvsspam/collect_diffs.rb:314: warning: Insecure world > > > writable dir /tmp, mode 040777 > > > /usr/local/lib/cvsspam/cvsspam.rb:1820: warning: Insecure world > > > writable dir /tmp, mode 040777 > > > > > > Success, CVS operation completed ta, dave From dave at badgers-in-foil.co.uk Thu Nov 30 00:23:44 2006 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Thu Nov 30 00:24:13 2006 Subject: [cvsspam-devel] Ruby with CVS and Ext/Ssh protocol and worldwritable /tmp dir In-Reply-To: <30A5F9D51C0D9D47BD8D89C85B49E700522D4F@EVS2.corp.rightnow.com> References: <20061129215316.GD15640@badgers-in-foil.co.uk> <30A5F9D51C0D9D47BD8D89C85B49E700522D4F@EVS2.corp.rightnow.com> Message-ID: <20061130002343.GE15640@badgers-in-foil.co.uk> On Wed, Nov 29, 2006 at 05:09:21PM -0700, McCullough, Ryan wrote: > What do you mean by "What credentials do you use with SSH/EXT?"? > > Hmm, when you use cvs with ssh/ext does it login as your unix user? That may > do it. I think so, yes. > So do I just need to remove the . From my path? It's worth a try, I guess. Hope that works, dave