[cvsspam-devel] encoding from header

[Elan Ruusamäe]

On Monday 11 July 2005 19:35:45 David Holroyd wrote:
> On Fri, Jul 08, 2005 at 04:49:56PM +0300, Elan Ruusam?e wrote:
> > but today i noticed some problem, particularilly, i have patch which
> > allows you to specify --charset argument to cvsspam [1], which will
> > override charset sent to outgoing email. it is used because different
> > locations in cvs have files in different encodings. but the problem is
> > that CVSROOT/users file is in constant encoding (iso8859-1 in my case),
> > and as a side effect the From header gets wrongly encoded.
> >
> > cvsspam called with --charset utf-8 parameter produces mail header:
> > From: Elan =?utf-8?q?Ruusam=e4e?= <glen at delfi.ee>
> >
> > perhaps you could look into this issue?
> >
> > [1] http://cvs.pld-linux.org/SOURCES/cvsspam-charset-arg.patch
>
> Would it be reasonable to try and detect the system character encoding,
> and use that in preference to the --charset argument?  Any idea how that
> detection should work?
>
> I've sometimes seen a charset appended to $LANG, but this is not the
> case on most of the systems I use.
>
> I guess that there could simply be an extra option to specify the
> encoding, but it would be nice for this to 'just work' without the need
> for extra config.

sorry for bringing up this old issue, how about adding config option which 
defines the charset of CVSROOT/users file? and if the variable is not 
defined, just default to --charset arg or 'iso8859-1'.

it just has to set proper encoding when encoding From header, no encoding 
coversion is neccessary.

currently sent out line:
From: Elan =?utf-8?q?Ruusam=e4e?= <glen at delfi.ee>

should be just:
From: Elan =?iso8859-1?q?Ruusam=e4e?= <glen at delfi.ee>

-- 
glen