From rmccullough at rightnow.com Thu Jan 17 21:19:14 2008 From: rmccullough at rightnow.com (McCullough, Ryan) Date: Thu, 17 Jan 2008 14:19:14 -0700 Subject: [cvsspam-devel] Diff listing not escaped properly Message-ID: <30A5F9D51C0D9D47BD8D89C85B49E70001AC7C1D@EVS2.corp.rightnow.com> Sometimes the last column of the listing is not escaping urls properly. It should display something like "1.1 -> 1.2" where each item is a link. Here are a couple entries I see: 1.1 < a href="http://bighorn/cgi-bin/viewcvs/repo/fitnesse/FitNesseRoot/DeveloperToo lkitSuite/RightNowToolkit/Added2008Q1/FattachSize/properties.xml.diff?r1=1.1 &r2=1.2">-> 1.2 1.11 - > 1.12 < /a> 1.1 < a href="http://bighorn/cgi-bin/viewcvs/repo/fitnesse/FitNesseRoot/DeveloperToo lkitSuite/RightNowToolkit/Added2008Q1/PerformanceSuite/properties.xml.diff?r 1=1.1&r2=1.2">-> 1.2 1.1 - > 1.2 < /tr> The checkin email had 163 modified files with +5875 and -570. If you need the raw email, let me know. Also, where is the subversion repository again? -Ryan Ryan McCullough | RightNow Technologies | Integration Tools Engineer 406-556-3162 office | Bozeman, MT | rmccullough at rightnow.com | http://www.rightnow.com -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/attachments/20080117/5f0a3245/attachment.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 3353 bytes Desc: not available Url : http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/attachments/20080117/5f0a3245/attachment.bin From dave at badgers-in-foil.co.uk Fri Jan 18 10:54:51 2008 From: dave at badgers-in-foil.co.uk (David Holroyd) Date: Fri, 18 Jan 2008 10:54:51 +0000 Subject: [cvsspam-devel] Diff listing not escaped properly In-Reply-To: <30A5F9D51C0D9D47BD8D89C85B49E70001AC7C1D@EVS2.corp.rightnow.com> References: <30A5F9D51C0D9D47BD8D89C85B49E70001AC7C1D@EVS2.corp.rightnow.com> Message-ID: <20080118105450.GA25473@badgers-in-foil.co.uk> On Thu, Jan 17, 2008 at 02:19:14PM -0700, McCullough, Ryan wrote: > Sometimes the last column of the listing is not escaping urls properly. It > should display something like "1.1 -> 1.2" where each item is a link. Here > are a couple entries I see: > > 1.1 < a href="http://bighorn/cgi-bin/viewcvs/repo/fitnesse/FitNesseRoot/DeveloperToolkitSuite/RightNowToolkit/Added2008Q1/FattachSize/properties.xml.diff?r1=1.1&r2=1.2">-> 1.2 > The checkin email had 163 modified files with +5875 and -570. > > If you need the raw email, let me know. Last I saw corruption of that kind, it was due to the email containing ultra-long lines (of HTML source). Some SMTP servers will break long lines to bring them back in line with the SMTP spec (which IIRC makes reference to a 199 character limit, or something close). If the gap between the '<' and the 'a' in the source of the message above is linebreak, then this is probably the issue. These days, CVSspam inserts a few extra linebreaks into the HTML, but deep repository paths in the ViewCVS URLs (for example) could still hit the limit. The proper fix is to encode the email body (I forget what the encoding is called) as this provides a way to break long lines such that the breaks disappear again when the message body is decoded. I didn't bother implementing that at the time because it further increases the already 'chunky' message size (oh, and I'm lazy too). > Also, where is the subversion repository again? Here you go, http://svn.badgers-in-foil.co.uk/cvsspam/trunk/ ta, dave -- http://david.holroyd.me.uk/ From vinnie.nolan at gmail.com Wed Jan 30 17:38:25 2008 From: vinnie.nolan at gmail.com (vinnie nolan) Date: Wed, 30 Jan 2008 17:38:25 +0000 Subject: [cvsspam-devel] Encrypting CVS notification emails Message-ID: Hi I wonder if it would be possible to configure cvsspam to encrypt all notification emails sent by CVS . Some notification emails could contain potentially sensitive information so it would make sense to encrypt them. The emails would be encrypted with a single certificate which is stored in PEM format in a local file. To encrypt an email using openssl and sendmail is quite simple. Just use the following format: $ openssl smime -encrypt \ -text \ -in myMessage.txt \ # Text to encrypt -from me at somewhere.com\ -to you at somewhere.com \ -subject "Encrypted CVS notification message" \ yourcert.pem \ # PEM certificate of user you want to send the email to. This could be the same file for all users on a mailing list. | /usr/sbin/sendmail you at somewhere.com I am not an expert on ruby so I am wondering if it is possible to invoke sendmail in this way from the cvsspam.rb file.. Many thanks in advance for any help. Vinnie See also: * http://www.linuxdevcenter.com/pub/a/linux/2003/09/04/email_pki.html?page=last * -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/attachments/20080130/15c02915/attachment.htm