[cvsspam-devel] Diff listing not escaped properly

[David Holroyd]

On Thu, Jan 17, 2008 at 02:19:14PM -0700, McCullough, Ryan wrote:
> Sometimes the last column of the listing is not escaping urls properly. It
> should display something like "1.1 -> 1.2" where each item is a link. Here
> are a couple entries I see:
> 
> 1.1 < a href="http://bighorn/cgi-bin/viewcvs/repo/fitnesse/FitNesseRoot/DeveloperToolkitSuite/RightNowToolkit/Added2008Q1/FattachSize/properties.xml.diff?r1=1.1&r2=1.2">-> 1.2

> The checkin email had 163 modified files with +5875 and -570.
> 
> If you need the raw email, let me know.

Last I saw corruption of that kind, it was due to the email containing
ultra-long lines (of HTML source).  Some SMTP servers will break long
lines to bring them back in line with the SMTP spec (which IIRC makes
reference to a 199 character limit, or something close).

If the gap between the '<' and the 'a' in the source of the message
above is linebreak, then this is probably the issue.

These days, CVSspam inserts a few extra linebreaks into the HTML, but
deep repository paths in the ViewCVS URLs (for example) could still hit
the limit.

The proper fix is to encode the email body (I forget what the encoding
is called) as this provides a way to break long lines such that the
breaks disappear again when the message body is decoded.

I didn't bother implementing that at the time because it further
increases the already 'chunky' message size (oh, and I'm lazy too).


> Also, where is the subversion repository again?

Here you go,

  http://svn.badgers-in-foil.co.uk/cvsspam/trunk/


ta,
dave

-- 
http://david.holroyd.me.uk/