From glen at delfi.ee Wed Mar 4 19:59:55 2009 From: glen at delfi.ee (Elan =?iso-8859-1?q?Ruusam=E4e?=) Date: Wed, 4 Mar 2009 21:59:55 +0200 Subject: [cvsspam-devel] trac links for svn Message-ID: <200903042159.55310.glen@delfi.ee> hi i've made patch to add trac (http://trac.edgewall.org/) links to svn commits. however the patch applies ok to trunk too (cvsspam) http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/cvsspam-trac.patch the concept of cvs and svn is a little different, but at least the links go somewhere :) what's the status of svn patch anyway, anyone reporting success stories, maybe time to merge with trunk? i myself after half hour hacking got the emails, but somewhy i get tmp trash laying around and therefore the exception: Committed revision 1523. Warning: post-commit hook failed (exit code 1) with output: cvsspam.rb: Using config '/etc/cvsspam/cvsspam.conf' cvsspam.rb: invoking '/usr/sbin/sendmail -t -oi' cvsspam.rb: Mail From: cvsspam.rb: leaving file /tmp/#svnspam.28638.0-1111089/logfile.emailtmp /srv/svn/hooks/svn_post_commit_hook.rb:33:in `rmdir': Directory not empty - /tmp/#svnspam.28638.0-1111089 (Errno::ENOTEMPTY) from /srv/svn/hooks/svn_post_commit_hook.rb:33:in `cleanup' from /srv/svn/hooks/svn_post_commit_hook.rb:310:in `main' from /srv/svn/hooks/svn_post_commit_hook.rb:314 # l /tmp/#svnspam.28638.0-1111089/ total 4.0K -rw-rw---- 1 root root 2.4K 2009-03-04 21:57 logfile.emailtmp -- glen From glen at delfi.ee Wed Mar 4 20:07:54 2009 From: glen at delfi.ee (Elan =?iso-8859-1?q?Ruusam=E4e?=) Date: Wed, 4 Mar 2009 22:07:54 +0200 Subject: [cvsspam-devel] trac links for svn In-Reply-To: <200903042159.55310.glen@delfi.ee> References: <200903042159.55310.glen@delfi.ee> Message-ID: <200903042207.54959.glen@delfi.ee> On Wednesday 04 March 2009 21:59:55 Elan Ruusam?e wrote: > i myself after half hour hacking got the emails, but somewhy i get tmp > trash laying around and therefore the exception: > > > Committed revision 1523. > > Warning: post-commit hook failed (exit code 1) with output: > cvsspam.rb: Using config '/etc/cvsspam/cvsspam.conf' > cvsspam.rb: invoking '/usr/sbin/sendmail -t -oi' > cvsspam.rb: Mail From: > cvsspam.rb: leaving file /tmp/#svnspam.28638.0-1111089/logfile.emailtmp > /srv/svn/hooks/svn_post_commit_hook.rb:33:in `rmdir': Directory not empty - > /tmp/#svnspam.28638.0-1111089 (Errno::ENOTEMPTY) from > /srv/svn/hooks/svn_post_commit_hook.rb:33:in `cleanup' from > /srv/svn/hooks/svn_post_commit_hook.rb:310:in `main' > ? ? ? ? from /srv/svn/hooks/svn_post_commit_hook.rb:314 ah, the problem was that in debug mode cvsspam.rb left tmp files around, patch to fix this: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/cvsspam-svnspam.patch?r1=1.1 -- glen From glen at delfi.ee Wed Mar 4 20:55:53 2009 From: glen at delfi.ee (Elan =?iso-8859-1?q?Ruusam=E4e?=) Date: Wed, 4 Mar 2009 22:55:53 +0200 Subject: [cvsspam-devel] CVSspam for subversion In-Reply-To: References: Message-ID: <200903042255.54083.glen@delfi.ee> On Thursday 09 March 2006 05:55:14 Joe Eiler wrote: > The second "svn_support" patch adds the stuff related to subversion. why the patch adds this $shortrepo? it breaks my setup (worked before applying this patchset) as the leading svn repository root name (basename actually) is added to the path, like it was svn path, making web links invalid. perhaps it could be added as optionally, maybe some new hook<>cvsspam.rb protocol, like "#R {$shortrepo}" (not sure what those #M, etc do) or simpliest would just be option to svn_post_commit_hook.rb argument? def process_modified_binary_diff(out, lines, path) - prev_rev= "unknown" - next_rev= "unknown" + prev_rev= $revision-1 + next_rev= $revision out.puts "#V #{prev_rev},#{next_rev}" - out.puts "#M #{path}" + out.puts "#M #{$shortrepo}/#{path}" out.puts "#U diff x x" out.puts "#U Binary files x and y differ" -- glen From glen at delfi.ee Wed Mar 4 23:52:02 2009 From: glen at delfi.ee (Elan =?utf-8?q?Ruusam=C3=A4e?=) Date: Thu, 5 Mar 2009 01:52:02 +0200 Subject: [cvsspam-devel] diffs not character safe In-Reply-To: <200703160217.32258.glen@delfi.ee> References: <200703061235.36645.glen@delfi.ee> <20070307235959.GA3600@badgers-in-foil.co.uk> <200703160217.32258.glen@delfi.ee> Message-ID: <200903050152.02602.glen@delfi.ee> On Friday 16 March 2007 02:17:32 Elan Ruusam?e wrote: > the email contains (seen with less): > ?
-+ ? ? ? 'map_tab_label' ? ? ? ? ? ?
> ? ? => '?????', 
++ ? ? ?
> 'map_tab_label' ? ? ? ? ? ? ? ? => ' id="addedchars"><9A>????'
>
> so my guess is, it worked for "removed", but did not for "added"

i was right. simple similar fix for the "addedchars" solves it.

-- 
glen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: m.patch
Type: text/x-diff
Size: 504 bytes
Desc: not available
Url : http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/attachments/20090305/db7f4bac/attachment.patch 

From dave at badgers-in-foil.co.uk  Thu Mar  5 08:10:00 2009
From: dave at badgers-in-foil.co.uk (David Holroyd)
Date: Thu, 5 Mar 2009 08:10:00 +0000
Subject: [cvsspam-devel] [cvsspam-devel-bounces@lists.badgers-in-foil.co.uk:
	Auto-discard notification]
Message-ID: <20090305081000.GA8007@badgers-in-foil.co.uk>


-------------- next part --------------
An embedded message was scrubbed...
From: cvsspam-devel-bounces at lists.badgers-in-foil.co.uk
Subject: Auto-discard notification
Date: Thu, 05 Mar 2009 03:35:46 +0000
Size: 5644
Url: http://lists.badgers-in-foil.co.uk/pipermail/cvsspam-devel/attachments/20090305/7312c498/attachment.eml 

From glen at delfi.ee  Thu Mar  5 17:49:23 2009
From: glen at delfi.ee (Elan =?iso-8859-1?q?Ruusam=E4e?=)
Date: Thu, 5 Mar 2009 19:49:23 +0200
Subject: [cvsspam-devel] CVSspam for subversion
In-Reply-To: 
References: 
	<200903042255.54083.glen@delfi.ee>
	
Message-ID: <200903051949.23447.glen@delfi.ee>

On Thursday 05 March 2009 05:54:35 Joe Eiler wrote:
> I honestly don't remember for sure why I had to put that in there.  But hey
> it was almost 3 years ago.
>
> I thought I needed that to get web links to work, but it could be that
> viewcvs changed or that you just have it setup differently.  The 3 servers
> I installed it on were still working fine last I checked.
ok, i consider it was just local hack and should be removed :)

ps: it was in svn intregration part, not cvs (svn_post_commit_hook.rb)

> As far as tmp files laying around when debug was on I think that was by
> design.  The tmp files can be very useful depending on what you are
> debugging.

fixed that already by not removing tmpdir in debug mode.

-- 
glen