[metaas-dev] Contributing

[David Holroyd]

Hey!

On Sat, Dec 29, 2007 at 02:01:25PM -0500, Matthew J Tretter wrote:
> 1.  Do you have a system in place for allowing other to contribute to
> metaas?  I'm making some changes now and wondering if there's any way
> they'll be absorbed back into the trunk.

Send 'unified diff'-style patches.  This is the default output format of
a 'svn diff' on the command line, so probably not much to worry about.

I'll apply the patches and commit to the repository.

It would be really good to have some unit tests for new code too.  (In
fact the Cobertura 'checks' that are in place should mean that Maven
will start failing the build if code coverage drops significantly ;)


> 2.  Do you have any ideas for the interfaces of expressions that
> haven't yet been written?  i.e. assignment expressions, etc.  I'd like
> to work on them but would like to stick with any guidelines or roadmap
> that you're working by.

I've looked to things like Spoon,

  http://spoon.gforge.inria.fr/mvnsites/spoon-core/apidocs/index.html

the Eclipse DOM,

  http://publib.boulder.ibm.com/infocenter/radhelp/v6r0m1/topic/org.eclipse.jdt.doc.isv/reference/api/overview-summary.html

and Sun's CodeModel,

  https://codemodel.dev.java.net/

for inspiration in the structuring of the API.


All these APIs define separate interfaces for assignments vs. other
kinds of expression, so it was my intention to do the same.  Then an
inner class to enumerate the different assignment operator types, per
ASBinaryExpression.


> 3.  ASDeclarationStatement has a method named setContant (which I
> think is a typo).

Indeed!  I'll fix it...


ta,
dave

-- 
http://david.holroyd.me.uk/