<html>
<head>
<style><!--
body {background-color:#ffffff;}
.file {border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;}
.pathname {font-family:monospace; float:right;}
.fileheader {margin-bottom:.5em;}
.diff {margin:0;}
.tasklist {padding:4px;border:1px dashed #000000;margin-top:1em;}
.tasklist ul {margin-top:0;margin-bottom:0;}
tr.alt {background-color:#eeeeee}
#added {background-color:#ddffdd;}
#addedchars {background-color:#99ff99;font-weight:bolder;}
tr.alt #added {background-color:#ccf7cc;}
#removed {background-color:#ffdddd;}
#removedchars {background-color:#ff9999;font-weight:bolder;}
tr.alt #removed {background-color:#f7cccc;}
#copied {background-color:#ccccff;}
tr.alt #copied {background-color:#bbbbf7;}
#info {color:#888888;}
#context {background-color:#eeeeee;}
td {padding-left:.3em;padding-right:.3em;}
tr.head {border-bottom-width:1px;border-bottom-style:solid;}
tr.head td {padding:0;padding-top:.2em;}
.task {background-color:#ffff00;}
.comment {white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;white-space:pre-wrap;word-wrap:break-word;padding:4px;border:1px dashed #000000;background-color:#ffffdd}
.error {color:red;}
hr {border-width:0px;height:2px;background:black;}
--></style>
</head>
<body>
<table cellspacing="0" cellpadding="0" border="0" rules="cols">
<tr class="head"><td colspan="5">Commit in <b><tt>metaas/trunk/src</tt></b></td></tr>
<tr><td><tt>main/java/uk/co/badgersinfoil/metaas/impl/<a href="#file1">ASTDocComment.java</a></tt> </td><td></td><td align="right" id="added">+1</td><td></td><td nowrap="nowrap" align="center">433 -> 434</td></tr>
<tr class="alt"><td><tt> /<a href="#file2">DocCommentUtils.java</a></tt> </td><td></td><td align="right" id="added">+2</td><td align="right" id="removed">-2</td><td nowrap="nowrap" align="center">433 -> 434</td></tr>
<tr><td><tt>test/java/uk/co/badgersinfoil/metaas/<a href="#file3">DocCommentTests.java</a></tt> </td><td></td><td align="right" id="added">+9</td><td></td><td nowrap="nowrap" align="center">433 -> 434</td></tr>
<tr><td></td><td></td><td align="right" id="added">+12</td><td align="right" id="removed">-2</td><td></td></tr>
</table>
<small id="info">3 modified files</small><br />
<pre class="comment">
improve checking of comments
</pre>
<hr /><a name="file1" /><div class="file">
<span class="pathname">metaas/trunk/src/main/java/uk/co/badgersinfoil/metaas/impl</span><br />
<div class="fileheader"><big><b>ASTDocComment.java</b></big> <small id="info">433 -> 434</small></div>
<pre class="diff"><small id="info">--- trunk/src/main/java/uk/co/badgersinfoil/metaas/impl/ASTDocComment.java 2007-02-24 15:31:47 UTC (rev 433)
+++ trunk/src/main/java/uk/co/badgersinfoil/metaas/impl/ASTDocComment.java 2007-02-24 15:39:05 UTC (rev 434)
@@ -50,6 +50,7 @@
</small></pre><pre class="diff" id="context"> }
public void addParaTag(String name, String body) {
</pre><pre class="diff" id="added">+ DocCommentUtils.assertValidContent(body);
</pre><pre class="diff" id="context"> String newline = DocCommentUtils.getNewlineText(ast, javadoc);
body = body.replaceAll("\n", newline);
if (javadoc == null) {
</pre></div>
<hr /><a name="file2" /><div class="file">
<span class="pathname">metaas/trunk/src/main/java/uk/co/badgersinfoil/metaas/impl</span><br />
<div class="fileheader"><big><b>DocCommentUtils.java</b></big> <small id="info">433 -> 434</small></div>
<pre class="diff"><small id="info">--- trunk/src/main/java/uk/co/badgersinfoil/metaas/impl/DocCommentUtils.java 2007-02-24 15:31:47 UTC (rev 433)
+++ trunk/src/main/java/uk/co/badgersinfoil/metaas/impl/DocCommentUtils.java 2007-02-24 15:39:05 UTC (rev 434)
@@ -119,7 +119,7 @@
</small></pre><pre class="diff" id="context"> }
}
</pre><pre class="diff" id="removed">- p<span id="removedchars">rivate</span> static void assertValidContent(String text) {
</pre><pre class="diff" id="added">+ p<span id="addedchars">ublic</span> static void assertValidContent(String text) {
</pre><pre class="diff" id="context"> int pos = text.indexOf("*/");
if (pos != -1) {
throw new SyntaxException("End-on-comment marker found at position "+pos);
</pre><pre class="diff"><small id="info">@@ -176,7 +176,6 @@
</small></pre><pre class="diff" id="context"> }
public static void setDescriptionString(LinkedListTree ast, String description) {
</pre><pre class="diff" id="removed">- assertValidContent(description);
</pre><pre class="diff" id="context"> LinkedListToken doc = findDocCommentToken(ast);
LinkedListTree javadoc = null;
LinkedListTree desc = null;
</pre><pre class="diff"><small id="info">@@ -192,6 +191,7 @@
</small></pre><pre class="diff" id="context"> }
return;
}
</pre><pre class="diff" id="added">+ assertValidContent(description);
</pre><pre class="diff" id="context"> String newline = getNewlineText(ast, javadoc);
if (!description.startsWith("\n")) {
description = "\n" + description;
</pre></div>
<hr /><a name="file3" /><div class="file">
<span class="pathname">metaas/trunk/src/test/java/uk/co/badgersinfoil/metaas</span><br />
<div class="fileheader"><big><b>DocCommentTests.java</b></big> <small id="info">433 -> 434</small></div>
<pre class="diff"><small id="info">--- trunk/src/test/java/uk/co/badgersinfoil/metaas/DocCommentTests.java 2007-02-24 15:31:47 UTC (rev 433)
+++ trunk/src/test/java/uk/co/badgersinfoil/metaas/DocCommentTests.java 2007-02-24 15:39:05 UTC (rev 434)
@@ -35,6 +35,15 @@
</small></pre><pre class="diff" id="context"> }
}
</pre><pre class="diff" id="added">+ public void testParaEndOfCommentMarker() {
+ try {
+ clazz.getDocumentation().addParaTag("foo", "*/");
+ fail("should not allow '*/' within a doc-comment");
+ } catch (SyntaxException e) {
+ // expected
+ }
+ }
+
</pre><pre class="diff" id="context"> public void testSetNewDescription() {
clazz.setDescription("hello");
assertEquals("hello", clazz.getDescriptionString().trim());
</pre></div>
<center><small><a href="http://www.badgers-in-foil.co.uk/projects/cvsspam/" title="commit -> email">CVSspam</a> 0.2.12</small></center>
</body></html>