<html>
<head>
<style><!--
body {background-color:#ffffff;}
.file {border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;}
.pathname {font-family:monospace; float:right;}
.fileheader {margin-bottom:.5em;}
.diff {margin:0;}
.tasklist {padding:4px;border:1px dashed #000000;margin-top:1em;}
.tasklist ul {margin-top:0;margin-bottom:0;}
tr.alt {background-color:#eeeeee}
#added {background-color:#ddffdd;}
#addedchars {background-color:#99ff99;font-weight:bolder;}
tr.alt #added {background-color:#ccf7cc;}
#removed {background-color:#ffdddd;}
#removedchars {background-color:#ff9999;font-weight:bolder;}
tr.alt #removed {background-color:#f7cccc;}
#copied {background-color:#ccccff;}
tr.alt #copied {background-color:#bbbbf7;}
#info {color:#888888;}
#context {background-color:#eeeeee;}
td {padding-left:.3em;padding-right:.3em;}
tr.head {border-bottom-width:1px;border-bottom-style:solid;}
tr.head td {padding:0;padding-top:.2em;}
.task {background-color:#ffff00;}
.comment {white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;white-space:pre-wrap;word-wrap:break-word;padding:4px;border:1px dashed #000000;background-color:#ffffdd}
.error {color:red;}
hr {border-width:0px;height:2px;background:black;}
--></style>
</head>
<body>
<table cellspacing="0" cellpadding="0" border="0" rules="cols">
<tr class="head"><td colspan="5">Commit in <b><tt>metaas/trunk/src/main/java/uk/co/badgersinfoil/metaas</tt></b></td></tr>
<tr><td><tt>dom/<a href="#file1">ASInvocationExpression.java</a></tt> </td><td></td><td align="right" id="added">+1</td><td align="right" id="removed">-7</td><td nowrap="nowrap" align="center">641 -> 642</td></tr>
<tr class="alt"><td><tt> /<a href="#file2">ASNewExpression.java</a></tt> </td><td></td><td align="right" id="added">+1</td><td align="right" id="removed">-1</td><td nowrap="nowrap" align="center">641 -> 642</td></tr>
<tr><td><tt> /<a href="#file3"><span id="added">Invocation.java</span></a></tt> </td><td></td><td align="right" id="added">+13</td><td></td><td nowrap="nowrap" align="right">added 642</td></tr>
<tr class="alt"><td><tt>impl/<a href="#file4">ASTASInvocationExpression.java</a></tt> </td><td></td><td align="right" id="added">+1</td><td align="right" id="removed">-22</td><td nowrap="nowrap" align="center">641 -> 642</td></tr>
<tr><td><tt> /<a href="#file5">ASTASNewExpression.java</a></tt> </td><td></td><td align="right" id="added">+1</td><td align="right" id="removed">-6</td><td nowrap="nowrap" align="center">641 -> 642</td></tr>
<tr class="alt"><td><tt> /<a href="#file6"><span id="added">ASTInvocation.java</span></a></tt> </td><td></td><td align="right" id="added">+34</td><td></td><td nowrap="nowrap" align="right">added 642</td></tr>
<tr><td></td><td></td><td align="right" id="added">+51</td><td align="right" id="removed">-36</td><td></td></tr>
</table>
<small id="info">2 added + 4 modified, total 6 files</small><br />
<pre class="comment">
ASNewExpression and ASInvocationExpression now both inherit common functionality from a common supertype, Invocation.
Previously, having ASInvocationExpression be the supertype of ASNewExpression
made it more fiddly to detect the kind of expression using simple instanceof
tests.
</pre>
<hr /><a name="file1" /><div class="file">
<span class="pathname">metaas/trunk/src/main/java/uk/co/badgersinfoil/metaas/dom</span><br />
<div class="fileheader"><big><b>ASInvocationExpression.java</b></big> <small id="info">641 -> 642</small></div>
<pre class="diff"><small id="info">--- trunk/src/main/java/uk/co/badgersinfoil/metaas/dom/ASInvocationExpression.java 2008-01-28 00:08:18 UTC (rev 641)
+++ trunk/src/main/java/uk/co/badgersinfoil/metaas/dom/ASInvocationExpression.java 2008-01-28 08:11:15 UTC (rev 642)
@@ -1,14 +1,8 @@
</small></pre><pre class="diff" id="context"> package uk.co.badgersinfoil.metaas.dom;
</pre><pre class="diff" id="removed">-import java.util.List;
-
</pre><pre class="diff" id="context"> /**
* An expression that invokes a method or function. For constructor
* invocations see {@link ASNewExpression}.
*/
</pre><pre class="diff" id="removed">-public interface ASInvocationExpression extends ASExpression {
- public ASExpression getTargetExpression();
- public void setTargetExpression(ASExpression expr);
- public List getArguments();
- public void setArguments(List args);
</pre><pre class="diff" id="added">+public interface ASInvocationExpression extends ASExpression, Invocation {
</pre><pre class="diff" id="context"> }
</pre></div>
<hr /><a name="file2" /><div class="file">
<span class="pathname">metaas/trunk/src/main/java/uk/co/badgersinfoil/metaas/dom</span><br />
<div class="fileheader"><big><b>ASNewExpression.java</b></big> <small id="info">641 -> 642</small></div>
<pre class="diff"><small id="info">--- trunk/src/main/java/uk/co/badgersinfoil/metaas/dom/ASNewExpression.java 2008-01-28 00:08:18 UTC (rev 641)
+++ trunk/src/main/java/uk/co/badgersinfoil/metaas/dom/ASNewExpression.java 2008-01-28 08:11:15 UTC (rev 642)
@@ -7,5 +7,5 @@
</small></pre><pre class="diff" id="context"> * 'new Ctor', rather than 'new Ctor()'), and in this case, getArguments()
* will return null.
*/
</pre><pre class="diff" id="removed">-public interface ASNewExpression extends AS<span id="removedchars">InvocationExpress</span>ion {
</pre><pre class="diff" id="added">+public interface ASNewExpression extends AS<span id="addedchars">Expression, Invocat</span>ion {
</pre><pre class="diff" id="context"> }
</pre></div>
<hr /><a name="file3" /><div class="file">
<span class="pathname" id="added">metaas/trunk/src/main/java/uk/co/badgersinfoil/metaas/dom</span><br />
<div class="fileheader" id="added"><big><b>Invocation.java</b></big> <small id="info">added at 642</small></div>
<pre class="diff"><small id="info">--- trunk/src/main/java/uk/co/badgersinfoil/metaas/dom/Invocation.java (rev 0)
+++ trunk/src/main/java/uk/co/badgersinfoil/metaas/dom/Invocation.java 2008-01-28 08:11:15 UTC (rev 642)
@@ -0,0 +1,13 @@
</small></pre><pre class="diff" id="added">+package uk.co.badgersinfoil.metaas.dom;
+
+import java.util.List;
+
+/**
+ * Common details for expressions which are invocations
+ */
+public interface Invocation {
+ public ASExpression getTargetExpression();
+ public void setTargetExpression(ASExpression expr);
+ public List getArguments();
+ public void setArguments(List args);
+}
</pre></div>
<hr /><a name="file4" /><div class="file">
<span class="pathname">metaas/trunk/src/main/java/uk/co/badgersinfoil/metaas/impl</span><br />
<div class="fileheader"><big><b>ASTASInvocationExpression.java</b></big> <small id="info">641 -> 642</small></div>
<pre class="diff"><small id="info">--- trunk/src/main/java/uk/co/badgersinfoil/metaas/impl/ASTASInvocationExpression.java 2008-01-28 00:08:18 UTC (rev 641)
+++ trunk/src/main/java/uk/co/badgersinfoil/metaas/impl/ASTASInvocationExpression.java 2008-01-28 08:11:15 UTC (rev 642)
@@ -1,33 +1,12 @@
</small></pre><pre class="diff" id="context"> package uk.co.badgersinfoil.metaas.impl;
</pre><pre class="diff" id="removed">-import java.util.List;
-import uk.co.badgersinfoil.metaas.dom.ASExpression;
</pre><pre class="diff" id="context"> import uk.co.badgersinfoil.metaas.dom.ASInvocationExpression;
import uk.co.badgersinfoil.metaas.impl.antlr.LinkedListTree;
</pre><pre class="diff" id="removed">-public class ASTASInvocationExpression extends AST<span id="removedchars">ASExpress</span>ion
</pre><pre class="diff" id="added">+public class ASTASInvocationExpression extends AST<span id="addedchars">Invocat</span>ion
</pre><pre class="diff" id="context"> implements ASInvocationExpression
{
public ASTASInvocationExpression(LinkedListTree ast) {
super(ast);
}
</pre><pre class="diff" id="removed">-
- public List getArguments() {
- LinkedListTree args = ArgumentUtils.findArgs(ast);
- return ArgumentUtils.astToExpressionList(args);
- }
-
- public ASExpression getTargetExpression() {
- return ExpressionBuilder.build(ast.getFirstChild());
- }
-
- public void setArguments(List args) {
- LinkedListTree argumentNode = ArgumentUtils.findArgs(ast);
- ArgumentUtils.overwriteArgsWithExpressionList(argumentNode, args);
- }
-
- public void setTargetExpression(ASExpression expr) {
- LinkedListTree exprAST = ((ASTASExpression)expr).getAST();
- ast.setChildWithTokens(0, exprAST);
- }
</pre><pre class="diff" id="context"> }
</pre><pre class="diff"><small id="info">\ No newline at end of file
</small></pre></div>
<hr /><a name="file5" /><div class="file">
<span class="pathname">metaas/trunk/src/main/java/uk/co/badgersinfoil/metaas/impl</span><br />
<div class="fileheader"><big><b>ASTASNewExpression.java</b></big> <small id="info">641 -> 642</small></div>
<pre class="diff"><small id="info">--- trunk/src/main/java/uk/co/badgersinfoil/metaas/impl/ASTASNewExpression.java 2008-01-28 00:08:18 UTC (rev 641)
+++ trunk/src/main/java/uk/co/badgersinfoil/metaas/impl/ASTASNewExpression.java 2008-01-28 08:11:15 UTC (rev 642)
@@ -1,17 +1,12 @@
</small></pre><pre class="diff" id="context"> package uk.co.badgersinfoil.metaas.impl;
</pre><pre class="diff" id="removed">-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.Iterator;
</pre><pre class="diff" id="context"> import java.util.List;
import org.asdt.core.internal.antlr.AS3Parser;
</pre><pre class="diff" id="removed">-
-import uk.co.badgersinfoil.metaas.dom.ASExpression;
</pre><pre class="diff" id="context"> import uk.co.badgersinfoil.metaas.dom.ASNewExpression;
import uk.co.badgersinfoil.metaas.impl.antlr.LinkedListTree;
</pre><pre class="diff" id="removed">-public class ASTASNewExpression extends AST<span id="removedchars">ASInvocationExpress</span>ion implements
</pre><pre class="diff" id="added">+public class ASTASNewExpression extends AST<span id="addedchars">Invocat</span>ion implements
</pre><pre class="diff" id="context"> ASNewExpression {
public ASTASNewExpression(LinkedListTree ast) {
</pre></div>
<hr /><a name="file6" /><div class="file">
<span class="pathname" id="added">metaas/trunk/src/main/java/uk/co/badgersinfoil/metaas/impl</span><br />
<div class="fileheader" id="added"><big><b>ASTInvocation.java</b></big> <small id="info">added at 642</small></div>
<pre class="diff"><small id="info">--- trunk/src/main/java/uk/co/badgersinfoil/metaas/impl/ASTInvocation.java (rev 0)
+++ trunk/src/main/java/uk/co/badgersinfoil/metaas/impl/ASTInvocation.java 2008-01-28 08:11:15 UTC (rev 642)
@@ -0,0 +1,34 @@
</small></pre><pre class="diff" id="added">+package uk.co.badgersinfoil.metaas.impl;
+
+import java.util.List;
+import uk.co.badgersinfoil.metaas.dom.ASExpression;
+import uk.co.badgersinfoil.metaas.dom.Invocation;
+import uk.co.badgersinfoil.metaas.impl.antlr.LinkedListTree;
+
+public class ASTInvocation implements Invocation {
+
+ protected LinkedListTree ast;
+
+ public ASTInvocation(LinkedListTree ast) {
+ this.ast = ast;
+ }
+
+ public List getArguments() {
+ LinkedListTree args = ArgumentUtils.findArgs(ast);
+ return ArgumentUtils.astToExpressionList(args);
+ }
+
+ public ASExpression getTargetExpression() {
+ return ExpressionBuilder.build(ast.getFirstChild());
+ }
+
+ public void setArguments(List args) {
+ LinkedListTree argumentNode = ArgumentUtils.findArgs(ast);
+ ArgumentUtils.overwriteArgsWithExpressionList(argumentNode, args);
+ }
+
+ public void setTargetExpression(ASExpression expr) {
+ LinkedListTree exprAST = ((ASTASExpression)expr).getAST();
+ ast.setChildWithTokens(0, exprAST);
+ }
+}
</pre></div>
<center><small><a href="http://www.badgers-in-foil.co.uk/projects/cvsspam/" title="commit -> email">CVSspam</a> 0.2.12</small></center>
</body></html>